Skip to content

Commit 39a92c0

Browse files
committed
add retry logging.
1 parent 84e0253 commit 39a92c0

2 files changed

Lines changed: 8 additions & 3 deletions

File tree

‎amber/src/test/scala/org/apache/amber/engine/e2e/DataProcessingSpec.scala‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ import akka.actor.{ActorSystem, Props}
2323
import akka.testkit.{ImplicitSender, TestKit}
2424
import akka.util.Timeout
2525
import com.twitter.util.{Await, Duration, Promise}
26+
import com.typesafe.scalalogging.Logger
2627
import org.apache.amber.clustering.SingleNodeListener
2728
import org.apache.amber.core.storage.DocumentFactory
2829
import org.apache.amber.core.storage.model.VirtualDocument
@@ -58,6 +59,8 @@ class DataProcessingSpec
5859

5960
implicit val timeout: Timeout = Timeout(5.seconds)
6061

62+
val logger: Logger = Logger("DataProcessingSpecLogger")
63+
6164
val workflowContext: WorkflowContext = new WorkflowContext()
6265

6366
override protected def beforeEach(): Unit = {
@@ -151,11 +154,12 @@ class DataProcessingSpec
151154
case _: com.twitter.util.TimeoutException =>
152155
attempt += 1
153156
if (attempt > maxRetries) {
154-
throw new com.twitter.util.TimeoutException("executeWorkflow timed out after retries")
157+
throw new com.twitter.util.TimeoutException("executeWorkflow failed after all retries!")
155158
}
156159
// Need to reset test texera_db state before retry
157160
cleanupWorkflowExecutionData()
158161
setUpWorkflowExecutionData()
162+
logger.info(s"executeWorkflow timed out. Retrying...")
159163
case otherError: Throwable =>
160164
throw otherError
161165
}

‎amber/src/test/scala/org/apache/amber/engine/e2e/PauseSpec.scala‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ class PauseSpec
5252

5353
implicit val timeout: Timeout = Timeout(5.seconds)
5454

55-
val logger = Logger("PauseSpecLogger")
55+
val logger: Logger = Logger("PauseSpecLogger")
5656

5757
override protected def beforeEach(): Unit = {
5858
setUpWorkflowExecutionData()
@@ -128,11 +128,12 @@ class PauseSpec
128128
case _: com.twitter.util.TimeoutException =>
129129
attempt += 1
130130
if (attempt > maxRetries) {
131-
throw new com.twitter.util.TimeoutException("shouldPause timed out after retries")
131+
throw new com.twitter.util.TimeoutException("shouldPause failed after all retries!")
132132
}
133133
// Need to reset test texera_db state before retry
134134
cleanupWorkflowExecutionData()
135135
setUpWorkflowExecutionData()
136+
logger.info(s"shouldPause timed out. Retrying...")
136137
case otherError: Throwable =>
137138
throw otherError
138139
}

0 commit comments

Comments
 (0)