Repository navigation
Commit 2082021
authored
refactor(frontend): remove the unreachable agent panel shadow (#8829)
### What changes were proposed in this PR?
Removes a class binding in `AgentPanelComponent` that can never apply.
**+1/−11 lines.** There is no behaviour change.
`<ul id="return-button">` has `[ngClass]="{'shadow': !width}"` and
`*ngIf="width"` on the **same element**. `*ngIf` creates the element
only while `width` is truthy, and `!width` is then always `false`. So
`shadow` is never set on a rendered element. `width` is a `number` that
is only ever 0, the 400px minimum, a resize width, or a range-checked
stored width, so there is no value that is both truthy and falsy.
The PR removes:
- the binding;
- the `.shadow` rule, which nothing else in this component's template
uses (the styles are encapsulated);
- `NgClass` from the imports, because this was the template's only
`ngClass`.
The `*ngIf` and every live style on the element stay.
### History
| | |
| --- | --- |
| **Introduced by** | #4020 (2025-11-25), "feat: introduce the LLM-based
workflow copilot": the binding, the `*ngIf` and the `.shadow` rule
together. #4873 (2026-05-03) later added the `NgClass` import when the
component became standalone |
| **Usage removed by** | **never used**. The binding has been
unreachable since the line was written. #4495 only moved the files |
It has never applied, in the ten months since it was added.
### Any related issues, documentation, discussions?
Closes #8828
### How was this PR tested?
No new tests; no spec referenced the class.
From `frontend/`:
- `npx ng test --watch=false
--include='**/agent-panel.component.spec.ts'
--include='**/workspace.component.spec.ts'`: 2 files, 86 tests, all
pass. These are the only specs that render the panel.
- `yarn format:ci`: clean.
- `npx ng build`: success.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5.5)
🤖 Generated with [Claude Code](https://claude.com/claude-code)1 parent b05b620 commit 2082021
3 files changed
Lines changed: 1 addition & 11 deletions
File tree
- frontend/src/app/workspace/component/agent/agent-panel
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
57 | 56 | | |
58 | 57 | | |
59 | 58 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | 73 | | |
82 | 74 | | |
83 | 75 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
| 27 | + | |
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
57 | 56 | | |
58 | 57 | | |
59 | 58 | | |
| |||
0 commit comments