Skip to content

Conversation

@kristw
Copy link
Contributor

@kristw kristw commented Mar 19, 2020

CATEGORY

Choose one

  • Enhancement (new features, refinement)

SUMMARY

Add tooltip support for polygon vis

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

From storybook
image

Also tested in Superset
image

TEST PLAN

Tested locally and in storybook

REVIEWERS

@codecov-io
Copy link

Codecov Report

Merging #9325 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9325      +/-   ##
==========================================
- Coverage   59.15%   59.08%   -0.08%     
==========================================
  Files         374      374              
  Lines       12168    12205      +37     
  Branches     2872     2989     +117     
==========================================
+ Hits         7198     7211      +13     
+ Misses       4970     4815     -155     
- Partials        0      179     +179     
Impacted Files Coverage Δ
...tend/src/dashboard/containers/FilterIndicators.jsx 77.77% <0.00%> (-9.73%) ⬇️
...nd/src/dashboard/containers/DashboardComponent.jsx 92.00% <0.00%> (-3.84%) ⬇️
...explore/components/controls/AdhocFilterControl.jsx 65.47% <0.00%> (-3.28%) ⬇️
superset-frontend/src/welcome/DashboardTable.jsx 75.00% <0.00%> (-2.42%) ⬇️
...et-frontend/src/SqlLab/components/LimitControl.jsx 87.17% <0.00%> (-2.30%) ⬇️
...set-frontend/src/SqlLab/components/QuerySearch.jsx 57.54% <0.00%> (-1.11%) ⬇️
...plore/components/controls/FixedOrMetricControl.jsx 51.78% <0.00%> (-0.95%) ⬇️
superset-frontend/src/explore/controls.jsx 40.14% <0.00%> (-0.90%) ⬇️
.../src/explore/components/AdhocMetricEditPopover.jsx 62.35% <0.00%> (-0.75%) ⬇️
...nd/src/explore/components/ExploreViewContainer.jsx 46.47% <0.00%> (-0.67%) ⬇️
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 104f3d2...6216e96. Read the comment docs.

@kristw kristw mentioned this pull request Mar 19, 2020
1 task
@kristw kristw force-pushed the kristw--bump-deckgl-poly branch from 6216e96 to d464b20 Compare March 19, 2020 23:56
@kristw kristw merged commit ccf21f6 into apache:master Mar 20, 2020
@kristw kristw deleted the kristw--bump-deckgl-poly branch March 20, 2020 00:51
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 First shipped in 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.36.0 First shipped in 0.36.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants