Skip to content

fix: cannot assign to read only property exports of object #9319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rusackas merged 3 commits into from
Mar 18, 2020
Merged

fix: cannot assign to read only property exports of object #9319

rusackas merged 3 commits into from
Mar 18, 2020

Conversation

@kristw
Copy link
Contributor

@kristw kristw commented Mar 18, 2020 •
edited
Loading

CATEGORY

Choose one

  • Build / Development Environment

SUMMARY

Fix the issue when npm link plugins

Uncaught TypeError: Cannot assign to read only property 'exports' of object '#<Object>'

TEST PLAN

Try npm link plugins

REVIEWERS

@suddjian @rusackas

@codecov-io
Copy link

codecov-io commented Mar 18, 2020 •
edited
Loading

Codecov Report

Merging #9319 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9319      +/-   ##
==========================================
+ Coverage   59.08%   59.15%   +0.07%     
==========================================
  Files         374      374              
  Lines       12205    12168      -37     
  Branches     2989     2872     -117     
==========================================
- Hits         7211     7198      -13     
- Misses       4815     4970     +155     
+ Partials      179        0     -179
Impacted Files Coverage Δ
...hboard/components/resizable/ResizableContainer.jsx 67.79% <0%> (-2.52%) ⬇️
...explore/components/AdhocMetricEditPopoverTitle.jsx 68.96% <0%> (-1.04%) ⬇️
...src/dashboard/components/HeaderActionsDropdown.jsx 68.88% <0%> (-0.68%) ⬇️
...nd/src/dashboard/components/gridComponents/Tab.jsx 66.17% <0%> (-0.5%) ⬇️
...erset-frontend/src/SqlLab/components/SqlEditor.jsx 51.65% <0%> (-0.3%) ⬇️
superset-frontend/src/components/EditableTitle.jsx 80% <0%> (-0.29%) ⬇️
...et-frontend/src/SqlLab/components/TableElement.jsx 82.55% <0%> (-0.21%) ⬇️
...c/dashboard/components/gridComponents/Markdown.jsx 91.66% <0%> (-0.12%) ⬇️
...tend/src/dashboard/util/getFilterScopeNodesTree.js 2.38% <0%> (ø) ⬆️
superset-frontend/src/setup/setupClient.js 0% <0%> (ø) ⬆️
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c36a7e3...906d6d7. Read the comment docs.

@rusackas
Copy link
Member

rusackas commented Mar 18, 2020

LGTM! Tested locally and it seems to be working better. Thank you for resolving this!

@rusackas rusackas merged commit 104f3d2 into apache:master Mar 18, 2020
@ktmud ktmud mentioned this pull request Mar 19, 2020
Merged
2 tasks
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 First shipped in 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rusackas rusackas rusackas approved these changes

Assignees

No one assigned

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.36.0 First shipped in 0.36.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kristw @codecov-io @rusackas @mistercrunch