Skip to content

[fix] Adding time grains to Table #8825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
john-bodley merged 1 commit into from
Dec 12, 2019
Merged

[fix] Adding time grains to Table #8825

john-bodley merged 1 commit into from
Dec 12, 2019

Conversation

@john-bodley
Copy link
Member

@john-bodley john-bodley commented Dec 12, 2019

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

This PR re-adds the time grain controls back to the Table visualization type as this is needed by the include_time control. Note this is the only visualization type which uses this control (per here).

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

to: @etr2460

etr2460
etr2460 approved these changes Dec 12, 2019
View reviewed changes
Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-io
Copy link

codecov-io commented Dec 12, 2019

Codecov Report

Merging #8825 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8825   +/-   ##
=======================================
  Coverage   65.88%   65.88%           
=======================================
  Files         483      483           
  Lines       24178    24178           
  Branches     2778     2778           
=======================================
  Hits        15930    15930           
  Misses       8070     8070           
  Partials      178      178

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec43609...db85432. Read the comment docs.

@john-bodley john-bodley merged commit 18fbe56 into master Dec 12, 2019
@john-bodley john-bodley deleted the john-bodley--fix-table-time-regression branch December 12, 2019 20:29
john-bodley added a commit to airbnb/superset-fork that referenced this pull request Dec 12, 2019
@john-bodley
[fix] Adding time grains to Table (apache#8825)
100bf28 
(cherry picked from commit 18fbe56)
@john-bodley john-bodley mentioned this pull request Mar 25, 2020
Merged
12 tasks
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 First shipped in 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@etr2460 etr2460 etr2460 approved these changes

Assignees

No one assigned

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.36.0 First shipped in 0.36.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@john-bodley @codecov-io @etr2460 @mistercrunch