Skip to content

[fix] Adding time grains to DualLine #8800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
john-bodley merged 1 commit into from
Dec 10, 2019
Merged

[fix] Adding time grains to DualLine #8800

john-bodley merged 1 commit into from
Dec 10, 2019

Conversation

@john-bodley
Copy link
Member

@john-bodley john-bodley commented Dec 10, 2019 •
edited
Loading

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Adds the missing time granularity controls to the DualLine visualization type. This is a regression introduced by #8674.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

to: @etr2460 @michellethomas

@codecov-io
Copy link

codecov-io commented Dec 10, 2019 •
edited
Loading

Codecov Report

Merging #8800 into master will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8800      +/-   ##
==========================================
+ Coverage   65.75%   65.91%   +0.15%     
==========================================
  Files         482      482              
  Lines       24157    24157              
  Branches     2770     2770              
==========================================
+ Hits        15885    15922      +37     
+ Misses       8094     8057      -37     
  Partials      178      178
Impacted Files Coverage Δ
superset/views/core.py 72.16% <0%> (+0.2%) ⬆️
superset/models/core.py 83.09% <0%> (+0.56%) ⬆️
superset/dataframe.py 94.48% <0%> (+1.57%) ⬆️
superset/db_engine_specs/mysql.py 92.59% <0%> (+51.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5477f42...3f63694. Read the comment docs.

@john-bodley john-bodley merged commit 2fb95cc into master Dec 10, 2019
john-bodley added a commit to airbnb/superset-fork that referenced this pull request Dec 10, 2019
@john-bodley
[fix] Adding time grains to DualLine (apache#8800)
d52d224 
(cherry picked from commit 2fb95cc)
@john-bodley john-bodley mentioned this pull request Mar 25, 2020
Merged
12 tasks
@amitmiran137 amitmiran137 deleted the john-bodley--fix-dual-line-time-regression branch March 29, 2021 18:09
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 First shipped in 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michellethomas michellethomas michellethomas approved these changes

Assignees

No one assigned

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.36.0 First shipped in 0.36.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@john-bodley @codecov-io @michellethomas @mistercrunch