Skip to content

Conversation

@mistercrunch
Copy link
Member

@coveralls
Copy link

coveralls commented Aug 8, 2017

Coverage Status

Coverage remained the same at 69.311% when pulling 5c7988c on mistercrunch:node_modules into 2385cd4 on apache:master.

@graceguo-supercat
Copy link

LGTM!

@graceguo-supercat
Copy link

@yolken with this change, we can safely remove node_modules, and don't need this change any more:
https://git.musta.ch/airbnb/superset-internal/pull/34/commits/525d1fd124e065efb1bbe09b0dc402bb1db7de0c
thank you!

@mistercrunch mistercrunch merged commit be01851 into apache:master Aug 9, 2017
@mistercrunch mistercrunch deleted the node_modules branch August 9, 2017 16:04
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Aug 10, 2017
mistercrunch pushed a commit that referenced this pull request Aug 11, 2017
* split reducer logic for ExploreViewContainer

* fix saveModal component and unit tests

* revert changes in SaveModal_spec.
will make another commit just to improve test coverage for SaveModal component.

* improve test coverage for explore view components:
- SaveModal component
- URLShortLinkButton

* remove comment-out code

* [bugfix] wrong 'Cant have overlap between Series and Breakdowns' (#3254)

* [explore] make edit datasource a basic link (#3244)

* Relying on FAB for font-awesome.min.css (#3261)

* Modernize SQLA pessimistic handling (#3256)

Looks like SQLAlchemy has redefined the best practice around
pessimistic connection handling.

* [webpack] break CSS and JS files while webpackin' (#3262)

* [webpack] break CSS and JS files while webpackin'

* cleaning up some templates

* Fix pylint issue

* import logging (#3264)

* [bugfix] preserve order in groupby (#3268)

Recently in
4c3313b
I introduced an issue where the order of groupby fields might change.

This addresses this issue and will preserve ordering.

* Explicitly add Flask as dependancy (#3252)

* Use sane Celery defaults to prevent tasks from being delayed (#3267)

* Improve the chart type of Visualize in sqllab (#3241)

* Improve the chart type of Visualize in sqllab & Add some css & Fix the link address in the navbar

* add vizTypes filter

* Set default ports Druid (#3266)

For Druid set the default port for the broker and coordinator.

* [explore] Split large reducer logic in ExploreViewContainer (#3088)

* split reducer logic for ExploreViewContainer

* fix saveModal component and unit tests

* revert changes in SaveModal_spec.
will make another commit just to improve test coverage for SaveModal component.

* remove comment-out code

* fix merge confilicts
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.19.1 First shipped in 0.19.1 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.19.1 First shipped in 0.19.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants