Skip to content

Conversation

@graceguo-supercat
Copy link

add unit tests for Explore view saveModal. These tests are based on sliced reducer (saveModalReducer).

@coveralls
Copy link

coveralls commented Aug 7, 2017

Coverage Status

Coverage remained the same at 69.311% when pulling b6da30f on graceguo-supercat:gg-ExploreViewSaveModalSpec into f68189b on apache:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.311% when pulling b6da30f on graceguo-supercat:gg-ExploreViewSaveModalSpec into f68189b on apache:master.

@mistercrunch
Copy link
Member

LGTM, want me to merge it since you don't have write access [yet]?

mistercrunch and others added 13 commits August 10, 2017 14:58
Looks like SQLAlchemy has redefined the best practice around
pessimistic connection handling.
* Improve the chart type of Visualize in sqllab & Add some css & Fix the link address in the navbar

* add vizTypes filter
* [webpack] break CSS and JS files while webpackin'

* cleaning up some templates

* Fix pylint issue
For Druid set the default port for the broker and coordinator.
Recently in
apache@4c3313b
I introduced an issue where the order of groupby fields might change.

This addresses this issue and will preserve ordering.
)

* split reducer logic for ExploreViewContainer

* fix saveModal component and unit tests

* revert changes in SaveModal_spec.
will make another commit just to improve test coverage for SaveModal component.

* remove comment-out code

* fix merge confilicts
@coveralls
Copy link

coveralls commented Aug 10, 2017

Coverage Status

Coverage remained the same at 69.315% when pulling 8fa7db8 on graceguo-supercat:gg-ExploreViewSaveModalSpec into b3107bb on apache:master.

@mistercrunch mistercrunch merged commit b68084b into apache:master Aug 11, 2017
@graceguo-supercat graceguo-supercat deleted the gg-ExploreViewSaveModalSpec branch August 15, 2017 22:27
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.19.1 First shipped in 0.19.1 labels Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.19.1 First shipped in 0.19.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants