chore: Convert deckgl class components to functional #25177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eschutho
approved these changes
Sep 7, 2023
Member
eschutho
left a comment
eschutho
left a comment
There was a problem hiding this comment.
LGTM. How's the test coverage on these components?
Member
Author
Tests are coming in a separate PR 🙂 |
Member
|
@kgabryje can you avoid the case without test codes next time since we always have hard time to fix the bugs and add a spec for this type of migrations. |
sebastiankruk
added a commit
to sebastiankruk/superset
that referenced
this pull request
Sep 9, 2023
* fix: Issue apache#24493; Resolved report selection menu in chart and dashboard page (apache#25157) * fix: DML failures in SQL Lab (apache#25190) * fix: All values being selected in Select (apache#25202) * docs: fix wrong type in PREFERRED_DATABASES example (apache#25200) Signed-off-by: cmontemuino <[email protected]> * docs: add CVEs for 2.1.1 (apache#25206) * chore: back port 2.1.1 doc changes (apache#25165) * feat(sqllab): Show sql in the current result (apache#24787) * docs(FAQ): add answer re: necessary specs, copy-edit existing answer (apache#24992) * fix: `is_select` (apache#25189) * fix: Cypress test to force mouseover (apache#25209) * fix(sqllab): Force trino client async execution (apache#24859) * fix: granularity_sqla and GENERIC_CHART_AXES (apache#25213) * chore: Convert deckgl class components to functional (apache#25177) * fix: Cypress test to force mouseover (follow-up) (apache#25223) * fix(docs): Fixing a typo in README.md (apache#25216) * chore(read_csv): remove deprecated argument (apache#25226) * chore(trino): remove unnecessary index checks (apache#25211) --------- Signed-off-by: cmontemuino <[email protected]> Co-authored-by: Sandeep Patel <[email protected]> Co-authored-by: Hugh A. Miles II <[email protected]> Co-authored-by: Michael S. Molina <[email protected]> Co-authored-by: Carlos M <[email protected]> Co-authored-by: Daniel Vaz Gaspar <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> Co-authored-by: JUST.in DO IT <[email protected]> Co-authored-by: Sam Firke <[email protected]> Co-authored-by: Beto Dealmeida <[email protected]> Co-authored-by: Rob Moore <[email protected]> Co-authored-by: Kamil Gabryjelski <[email protected]> Co-authored-by: yousoph <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]>
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🏷️ bot
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR converts every class component in deckgl plugins to functional. The goal is to make the code easier to read and maintain.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
No visual changes
TESTING INSTRUCTIONS
Every deck.gl chart should work exactly like it did before
ADDITIONAL INFORMATION