fix(sqllab): rollback clean comments out #24009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
reviewed
May 10, 2023
|
|
||
| const sqlContent = selectedText || sql || ''; | ||
| const isDisabled = cleanSqlComments(sqlContent).length === 0; | ||
| const isDisabled = |
Member
There was a problem hiding this comment.
Maybe outside the scope of this PR, but I wonder if we should remove the isDisable logic as well. Regex's scare me.
Codecov Report
@@ Coverage Diff @@
## master #24009 +/- ##
==========================================
- Coverage 68.21% 68.12% -0.10%
==========================================
Files 1941 1941
Lines 75279 75274 -5
Branches 8166 8167 +1
==========================================
- Hits 51350 51278 -72
- Misses 21840 21907 +67
Partials 2089 2089
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 15 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
9 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
There's a regression caused by #23378 and #23908
This commit rollbacks the commit relates to the cleanSqlComments
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
CI
ADDITIONAL INFORMATION