Skip to content

fix: Removes Redux state mutations - iteration 3 #23637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
michael-s-molina merged 2 commits into from
Apr 10, 2023
Merged

fix: Removes Redux state mutations - iteration 3 #23637

michael-s-molina merged 2 commits into from
Apr 10, 2023

Conversation

@michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Apr 10, 2023

SUMMARY

This iteration removes Redux state mutations from the codebase to allow us to merge #23460 without disrupting the development workflow.

TESTING INSTRUCTIONS

1 - Pull changes from #23460 to enable the immutabilityMiddleware
2 - Add or remove a native filter
3 - You shouldn't see any errors related to state mutation

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina
Copy link
Member Author

michael-s-molina commented Apr 10, 2023

@justinpark I tested all major workflows with the results of this and previous iterations and I was not able to generate immutability errors. There are many errors related to non-serializable objects being stored in Redux like BigNumbers and functions but these only generate warnings and don't block your PR. We can fix them in follow-ups.

@codecov
Copy link

codecov bot commented Apr 10, 2023 •
edited
Loading

Codecov Report

Merging #23637 (6744c18) into master (b613167) will increase coverage by 0.22%.
The diff coverage is 64.84%.

❗ Current head 6744c18 differs from pull request most recent head d3d7797. Consider uploading reports for the commit d3d7797 to get more accurate results

@@            Coverage Diff             @@
##           master   #23637      +/-   ##
==========================================
+ Coverage   67.71%   67.94%   +0.22%     
==========================================
  Files        1918     1918              
  Lines       74157    73882     -275     
  Branches     8053     8054       +1     
==========================================
- Hits        50219    50198      -21     
+ Misses      21885    21631     -254     
  Partials     2053     2053
Flag Coverage Δ
javascript 53.90% <16.66%> (-0.01%) ⬇️
presto ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/src/SqlLab/components/SaveDatasetModal/index.tsx 52.27% <0.00%> (ø)
superset-frontend/src/SqlLab/fixtures.ts 100.00% <ø> (ø)
...nents/controls/MetricControl/AdhocMetricOption.jsx 77.77% <0.00%> (ø)
...et-frontend/src/components/Chart/ChartRenderer.jsx 50.60% <33.33%> (-0.65%) ⬇️
superset/models/sql_lab.py 77.86% <42.85%> (+2.86%) ⬆️
superset/connectors/sqla/models.py 86.32% <63.63%> (-3.29%) ⬇️
superset/utils/core.py 90.99% <66.66%> (+0.08%) ⬆️
superset/models/helpers.py 68.69% <69.74%> (+30.04%) ⬆️
superset/views/core.py 75.27% <100.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

justinpark
justinpark reviewed Apr 10, 2023
View reviewed changes
@rusackas rusackas mentioned this pull request Apr 10, 2023
Merged
9 tasks
justinpark
justinpark approved these changes Apr 10, 2023
View reviewed changes
Copy link
Member

@justinpark justinpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michael-s-molina michael-s-molina merged commit 8bd8276 into apache:master Apr 10, 2023
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
@michael-s-molina @sebastianliebscher
fix: Removes Redux state mutations - iteration 3 (apache#23637)
55c138e
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 First shipped in 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinpark justinpark justinpark approved these changes

Assignees

No one assigned

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.0.0 First shipped in 3.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@michael-s-molina @justinpark @mistercrunch