Skip to content

Conversation

@EugeneTorap
Copy link
Contributor

@EugeneTorap EugeneTorap commented Nov 24, 2022

SUMMARY

Add Python 3.11 support for superset which gives huge performance improvements (25% is the average number claimed)

Bump next libs:

  • cffi==1.15.1
  • numpy==1.23.5
  • pandas==1.5.2
  • pyarrow==10.0.1

For Postgres bump psycopg2-binary to 2.9.5

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Merging #22217 (1aefa8d) into master (7bc5f04) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #22217      +/-   ##
==========================================
- Coverage   66.89%   66.88%   -0.02%     
==========================================
  Files        1847     1847              
  Lines       70333    70435     +102     
  Branches     7702     7702              
==========================================
+ Hits        47047    47108      +61     
- Misses      21288    21329      +41     
  Partials     1998     1998              
Flag Coverage Δ
hive 52.53% <ø> (-0.03%) ⬇️
mysql 77.96% <ø> (-0.09%) ⬇️
postgres 78.02% <ø> (-0.09%) ⬇️
presto 52.42% <ø> (-0.03%) ⬇️
python 81.24% <ø> (-0.07%) ⬇️
sqlite 76.49% <ø> (-0.09%) ⬇️
unit 50.92% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/databricks.py 64.96% <0.00%> (-17.97%) ⬇️
superset/result_set.py 97.85% <0.00%> (+0.03%) ⬆️
superset/connectors/sqla/models.py 89.36% <0.00%> (+0.04%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@villebro
Copy link
Member

villebro commented Dec 3, 2022

On this topic, I happened to come across this interesting Lex Friedman interview with Guido van Rossum about what the main optimizations are in 3.11: https://youtu.be/TLhRuZ9cJWc . Looking forward to JIT in a future version.. 😛

@pull-request-size pull-request-size bot added size/M and removed size/S labels Dec 3, 2022
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's follow up with pinning db-types to 1.0.5 once it comes out.

"athena": ["pyathena[pandas]>=2, <3"],
"aurora-data-api": ["preset-sqlalchemy-aurora-data-api>=0.2.8,<0.3"],
"bigquery": [
"db-dtypes @ git+https://[email protected]/googleapis/python-db-dtypes-pandas.git@388e082a47d9515a14e20ffd87705c71712087ab#egg=db-dtypes",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a hurry I see 😆

@villebro villebro merged commit d881c5d into apache:master Dec 3, 2022
@EugeneTorap EugeneTorap deleted the feat/support-python3.11 branch December 3, 2022 07:26
@mistercrunch mistercrunch added the 🚢 2.1.3 First shipped in 2.1.3 label Feb 18, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 First shipped in 2.1.0 and removed 🚢 2.1.3 First shipped in 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0 First shipped in 2.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants