Skip to content

chore: deprecate /superset/fetch_datasource_metadata mig to API v1 #22102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dpgaspar merged 1 commit into from
Nov 14, 2022
Merged

chore: deprecate /superset/fetch_datasource_metadata mig to API v1 #22102

dpgaspar merged 1 commit into from
Nov 14, 2022

Conversation

@dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Nov 11, 2022 •
edited
Loading

SUMMARY

Continuing the effort on deprecating all /superset/ REST API endpoints
Deprecates /superset/fetch_datasource_metadata replaced by the already existing /api/v1/dataset/<id>

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Nov 11, 2022 •
edited
Loading

Codecov Report

Merging #22102 (ac2eeb8) into master (5b67e07) will decrease coverage by 1.26%.
The diff coverage is 50.00%.

❗ Current head ac2eeb8 differs from pull request most recent head 4541927. Consider uploading reports for the commit 4541927 to get more accurate results

@@            Coverage Diff             @@
##           master   #22102      +/-   ##
==========================================
- Coverage   67.12%   65.86%   -1.27%     
==========================================
  Files        1831     1831              
  Lines       69993    69994       +1     
  Branches     7570     7570              
==========================================
- Hits        46983    46099     -884     
- Misses      21045    21930     +885     
  Partials     1965     1965
Flag Coverage Δ
hive 52.84% <0.00%> (-0.01%) ⬇️
mysql 78.40% <100.00%> (+<0.01%) ⬆️
postgres 78.46% <100.00%> (+<0.01%) ⬆️
presto 52.74% <0.00%> (-0.01%) ⬇️
python 78.94% <100.00%> (-2.64%) ⬇️
sqlite 76.93% <100.00%> (+<0.01%) ⬆️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/SqlLab/actions/sqlLab.js 62.85% <0.00%> (ø)
superset/datasets/api.py 87.39% <ø> (ø)
superset/views/core.py 75.94% <100.00%> (+0.01%) ⬆️
superset/tables/schemas.py 0.00% <0.00%> (-100.00%) ⬇️
superset/columns/schemas.py 0.00% <0.00%> (-100.00%) ⬇️
...set/advanced_data_type/plugins/internet_address.py 16.32% <0.00%> (-79.60%) ⬇️
superset/utils/pandas_postprocessing/boxplot.py 20.51% <0.00%> (-79.49%) ⬇️
superset/charts/post_processing.py 11.76% <0.00%> (-77.95%) ⬇️
...perset/advanced_data_type/plugins/internet_port.py 18.75% <0.00%> (-77.09%) ⬇️
superset/utils/pandas_postprocessing/rolling.py 21.87% <0.00%> (-68.75%) ⬇️
... and 55 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

villebro
villebro approved these changes Nov 11, 2022
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + tested to work as expected (it took me a while to figure out how to trigger this 😆). One more nail in the coffin! ⚰️🔨

@dpgaspar
Copy link
Member Author

dpgaspar commented Nov 14, 2022

Took me a while also, should have added an "how to test" on the PR description, will do that next time. Thank you once more for the review

@dpgaspar dpgaspar merged commit 7c6fabb into apache:master Nov 14, 2022
@dpgaspar dpgaspar deleted the danielgaspar/sc-42033/migrate-superset-fetch-datasource-metadata branch November 14, 2022 08:51
@justinpark justinpark mentioned this pull request Oct 23, 2023
Merged
9 tasks
@mistercrunch mistercrunch added the 🚢 2.1.3 First shipped in 2.1.3 label Feb 18, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 First shipped in 2.1.0 and removed 🚢 2.1.3 First shipped in 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@villebro villebro villebro approved these changes

@john-bodley john-bodley Awaiting requested review from john-bodley

Assignees

No one assigned

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0 First shipped in 2.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dpgaspar @villebro @mistercrunch