Skip to content

refactor: Remove obsolete HiveEngineSpec.fetch_logs method #20631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
john-bodley merged 1 commit into from
Sep 11, 2023
Merged

refactor: Remove obsolete HiveEngineSpec.fetch_logs method #20631

john-bodley merged 1 commit into from
Sep 11, 2023

Conversation

@john-bodley
Copy link
Member

@john-bodley john-bodley commented Jul 6, 2022 •
edited
Loading

SUMMARY

PyHive now contains the fetch_log method which makes the HiveEngineSpec.fetch_logs() method obsolete—per the comment it mentioned it should be contributed back to PyHive.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley john-bodley changed the title John bodley remove obsolete db engines refactor: Remove obsolete db_engines/hive.py Jul 6, 2022
@codecov
Copy link

codecov bot commented Jul 6, 2022 •
edited
Loading

Codecov Report

Merging #20631 (59437ea) into master (429f246) will increase coverage by 0.80%.
The diff coverage is n/a.

❗ Current head 59437ea differs from pull request most recent head d53bc04. Consider uploading reports for the commit d53bc04 to get more accurate results

@@            Coverage Diff             @@
##           master   #20631      +/-   ##
==========================================
+ Coverage   65.76%   66.56%   +0.80%     
==========================================
  Files        1813     1791      -22     
  Lines       69437    68609     -828     
  Branches     7450     7318     -132     
==========================================
+ Hits        45667    45672       +5     
+ Misses      21850    21044     -806     
+ Partials     1920     1893      -27
Flag Coverage Δ
hive 52.93% <0.00%> (+0.06%) ⬆️
javascript 52.75% <0.00%> (-0.74%) ⬇️
mysql 78.08% <0.00%> (-0.31%) ⬇️
postgres 78.14% <0.00%> (-0.30%) ⬇️
presto 52.83% <0.00%> (+0.06%) ⬆️
python 81.30% <0.00%> (+2.38%) ⬆️
sqlite 76.64% <0.00%> (-0.27%) ⬇️
unit 50.96% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-chart-table/src/DataTable/utils/useMountedMemo.ts 0.00% <0.00%> (-87.50%) ⬇️
...lUtils/getControlValuesCompatibleWithDatasource.ts 7.69% <0.00%> (-73.79%) ⬇️
...trols/DateFilterControl/components/CommonFrame.tsx 0.00% <0.00%> (-57.15%) ⬇️
superset-frontend/src/utils/getDatasourceUid.ts 50.00% <0.00%> (-50.00%) ⬇️
...ugin-chart-table/src/DataTable/hooks/useSticky.tsx 4.21% <0.00%> (-47.37%) ⬇️
...s/CRUD/data/dataset/AddDataset/LeftPanel/index.tsx 46.42% <0.00%> (-38.19%) ⬇️
...chart-controls/src/shared-controls/dndControls.tsx 28.30% <0.00%> (-30.04%) ⬇️
...d/src/views/CRUD/data/dataset/AddDataset/index.tsx 33.33% <0.00%> (-24.57%) ⬇️
superset-frontend/src/components/Select/styles.tsx 81.13% <0.00%> (-18.87%) ⬇️
...perset-frontend/src/views/components/RightMenu.tsx 60.83% <0.00%> (-17.64%) ⬇️
... and 404 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@john-bodley john-bodley force-pushed the john-bodley-remove-obsolete-db_engines branch from d04bd8f to 4b1dca2 Compare September 13, 2022 15:29
@john-bodley john-bodley mentioned this pull request Oct 28, 2022
Closed
@john-bodley john-bodley force-pushed the john-bodley-remove-obsolete-db_engines branch from 4b1dca2 to d53bc04 Compare November 2, 2022 21:32
@john-bodley john-bodley force-pushed the john-bodley-remove-obsolete-db_engines branch from d53bc04 to cd6b271 Compare November 18, 2022 20:42
@john-bodley john-bodley force-pushed the john-bodley-remove-obsolete-db_engines branch from cd6b271 to eb794a2 Compare December 6, 2022 23:44
@john-bodley john-bodley mentioned this pull request Jan 4, 2023
Merged
9 tasks
@john-bodley john-bodley force-pushed the john-bodley-remove-obsolete-db_engines branch from eb794a2 to 37265bd Compare September 1, 2023 20:33
@john-bodley
Delete __init__.py
e9ed8ee 
Delete hive.py

Update hive.py
@john-bodley john-bodley force-pushed the john-bodley-remove-obsolete-db_engines branch from 37265bd to e9ed8ee Compare September 1, 2023 21:31
@john-bodley john-bodley changed the title refactor: Remove obsolete db_engines/hive.py refactor: Remove obsolete HiveEngineSpec.fetch_logs method Sep 1, 2023
bkyryliuk
bkyryliuk approved these changes Sep 2, 2023
View reviewed changes
Copy link
Member

@bkyryliuk bkyryliuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup !

michael-s-molina
michael-s-molina approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@john-bodley john-bodley merged commit 83fc553 into master Sep 11, 2023
@john-bodley john-bodley deleted the john-bodley-remove-obsolete-db_engines branch September 11, 2023 16:00
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@john-bodley
refactor: Remove obsolete HiveEngineSpec.fetch_logs method (apache#20631
3f95c12 
)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 First shipped in 3.1.0 labels Mar 13, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@john-bodley
refactor: Remove obsolete HiveEngineSpec.fetch_logs method (apache#20631
e7bc64b 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkyryliuk bkyryliuk bkyryliuk approved these changes

@michael-s-molina michael-s-molina michael-s-molina approved these changes

@betodealmeida betodealmeida Awaiting requested review from betodealmeida

Assignees

No one assigned

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.1.0 First shipped in 3.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@john-bodley @bkyryliuk @michael-s-molina @mistercrunch