feat: add support for filters in sqlLab #14765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #14765 +/- ##
==========================================
- Coverage 77.52% 77.37% -0.15%
==========================================
Files 960 963 +3
Lines 48819 49336 +517
Branches 6120 6230 +110
==========================================
+ Hits 37847 38176 +329
- Misses 10769 10961 +192
+ Partials 203 199 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
cccs-jc
force-pushed
the
support_filters_in_sqllab
branch
from
5631687 to
e96e9e0
Compare
cccs-jc
force-pushed
the
support_filters_in_sqllab
branch
from
e96e9e0 to
f1e757a
Compare
villebro
approved these changes
May 31, 2021
Member
villebro
left a comment
villebro
left a comment
There was a problem hiding this comment.
LGTM - just needs to fix the underscore dangle lint error
added 2 commits
May 31, 2021 12:09
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
9 tasks
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQL lab can execute queries containing jinja templates.
You can specify key/values that your jinja template can use. However it's not possible to add additional filters like the Explore or the Dashboard would do.
This pull request adds support for filters provided in the sql lab parameters
This is very convenient to test templates since it behaves like the Explore or Dashboard.
Maybe the implementation details are not 100%. But I'm hoping the concept and ability to do this in sql lab is welcomed.