Skip to content

Superset 3.0.0 generates invalid SQL for Dremio after releasing #23872 #25554

@OskarNS

Description

@OskarNS

A clear and concise description of what the bug is.

How to reproduce the bug

  1. Create a new chart that has the options of Series Limit. Eg. Time-Series Chart, Area Chart etc.
  2. Set required fields and Series Limit
  3. Click Create Chart.
  4. See error

Expected results

The chart is shown successfully on the right.

Actual results

Unexpected error returned. Superset generates invalid SQL for Dremio, which then throws an error. See screenshots

Screenshots

image

Comparison of SQL generated for Dremio for a Time series chart in 3.0.0 and 2.1.1, respectively:
image

Environment

  • superset version: 3.0.0

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

This pull request has introduced the regression: #23872
This is also apparent in the above screenshots. The invalid SQL is due to aliases missing.

How should we proceed from there? Should #23872 be reverted?

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions