Skip to content

Update flask-caching version to 2.0+ to avoid breaking redis cache #25339

@ggbaro

Description

@ggbaro

A clear and concise description of what the bug is.

How to reproduce the bug

If we have flask-caching=~1.11.1 and cachelib>=9 (flask-caching did not pin down cahcelib dependency until 2.0, so it's very likely to happen...), we end up with this pallets-eco/flask-caching#381

caused by this very line:
https://github.com/pallets-eco/flask-caching/blob/ac13e01baa11d65c68dcba64f99ccaafd9b5419c/src/flask_caching/backends/rediscache.py#L62

The fix might be as small as this (even if I'd like to test more in depth): ggbaro@185e59e
Do you suggest to make a PR?

Expected results

App starts normally

Actual results

flask-caching breaks with redis cache

Environment

(please complete the following information):

  • browser type and version:
  • superset version: >=2
  • python version: 3.9 & 3.10

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions