Skip to content

Closed Sqllab tabs come back with no queries after refreshing #25289

@zhaorui2022

Description

@zhaorui2022

If we close all the tabs in Sqllab, and then refresh the page, all the previously closed tabs are back, but there is no actual queries in them. This issue happens in 2.0.0 as well since we had users reporting this issue with the production environment which was running on 2.0.0). But in 2.0.0, the query of the last tab still shows up.

How to reproduce the bug

  1. Go to Sqllab, open a few tabs and run queries
  2. Close all the tabs
  3. Refresh page
  4. See error

Expected results

The closed tabs are gone, and it opens a brand new tab

Actual results

Closed tabs are back with no query in it

Screenshots

Google Chrome - Superset 2023-09-13 at 3 41 20 PM

Environment

(please complete the following information):

  • browser type and version: Chrome latest version
  • superset version: superset version 3.0.0rc4
  • python version: python --version 3.9
  • node.js version: node -v N/A
  • any feature flags active: We have SQLLAB_BACKEND_PERSISTENCE set to False, so the tabs might have been stored in browser's local storage.

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions