[bugfix] wrong 'Cant have overlap between Series and Breakdowns'

mistercrunch · mistercrunch · commit c9da193dcd96 · 2017-08-08T03:39:38.000Z
diff --git a/superset/viz.py b/superset/viz.py
@@ -1088,13 +1088,13 @@ def query_obj(self):
         d = super(DistributionBarViz, self).query_obj()  # noqa
         fd = self.form_data
         if (
-                len(self.groupby) <
+                len(d['groupby']) <
                 len(fd.get('groupby') or []) + len(fd.get('columns') or [])
                 ):
             raise Exception("Can't have overlap between Series and Breakdowns")
-        if not self.metrics:
+        if not fd.get('metrics'):
             raise Exception("Pick at least one metric")
-        if not self.groupby:
+        if not fd.get('groupby'):
             raise Exception("Pick at least one field for [Series]")
         return d
 
