fix: chart import (#25425)

betodealmeida · web-flow · commit a4d8f36863e1 · 2023-09-26T19:31:34.000-07:00
diff --git a/superset/charts/commands/importers/v1/utils.py b/superset/charts/commands/importers/v1/utils.py
@@ -99,8 +99,8 @@ def migrate_chart(config: dict[str, Any]) -> dict[str, Any]:
 
     # also update `query_context`
     try:
-        query_context = json.loads(output.get("query_context", "{}"))
-    except json.decoder.JSONDecodeError:
+        query_context = json.loads(output.get("query_context") or "{}")
+    except (json.decoder.JSONDecodeError, TypeError):
         query_context = {}
     if "form_data" in query_context:
         query_context["form_data"] = output["params"]
diff --git a/tests/unit_tests/charts/commands/importers/v1/utils_test.py b/tests/unit_tests/charts/commands/importers/v1/utils_test.py
@@ -32,6 +32,7 @@ def test_migrate_chart_area() -> None:
         "certified_by": None,
         "certification_details": None,
         "viz_type": "area",
+        "query_context": None,
         "params": json.dumps(
             {
                 "adhoc_filters": [],

Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,7 @@ def test_migrate_chart_area() -> None:`
`32`	`32`	`"certified_by": None,`
`33`	`33`	`"certification_details": None,`
`34`	`34`	`"viz_type": "area",`
	`35`	`+ "query_context": None,`
`35`	`36`	`"params": json.dumps(`
`36`	`37`	`{`
`37`	`38`	`"adhoc_filters": [],`