Fix test.

codyml · codyml · commit 750074fa6e44 · 2023-01-23T11:45:45.000-07:00
diff --git a/superset-frontend/src/components/Form/LabeledErrorBoundInput.test.jsx b/superset-frontend/src/components/Form/LabeledErrorBoundInput.test.jsx
@@ -81,13 +81,13 @@ describe('LabeledErrorBoundInput', () => {
     defaultProps.visibilityToggle = true;
     render(<LabeledErrorBoundInput {...defaultProps} />);
 
-    expect(await screen.findByRole('img', { name: /eye/i })).toBeVisible();
+    expect(await screen.findByTestId('icon-eye')).toBeVisible();
   });
 
   it('becomes a password input if props.name === password (backwards compatibility)', async () => {
     defaultProps.name = 'password';
     render(<LabeledErrorBoundInput {...defaultProps} />);
 
-    expect(await screen.findByRole('img', { name: /eye/i })).toBeVisible();
+    expect(await screen.findByTestId('icon-eye')).toBeVisible();
   });
 });
diff --git a/superset-frontend/src/components/Form/LabeledErrorBoundInput.tsx b/superset-frontend/src/components/Form/LabeledErrorBoundInput.tsx
@@ -138,7 +138,11 @@ const LabeledErrorBoundInput = ({
               </Tooltip>
             ) : (
               <Tooltip title={t('Show password.')}>
-                <Icons.EyeOutlined iconSize="m" css={iconReset} />
+                <Icons.EyeOutlined
+                  iconSize="m"
+                  css={iconReset}
+                  data-test="icon-eye"
+                />
               </Tooltip>
             )
           }

Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,11 @@ const LabeledErrorBoundInput = ({`
`138`	`138`	`</Tooltip>`
`139`	`139`	`) : (`
`140`	`140`	`<Tooltip title={t('Show password.')}>`
`141`		`- <Icons.EyeOutlined iconSize="m" css={iconReset} />`
	`141`	`+ <Icons.EyeOutlined`
	`142`	`+ iconSize="m"`
	`143`	`+ css={iconReset}`
	`144`	`+ data-test="icon-eye"`
	`145`	`+ />`
`142`	`146`	`</Tooltip>`
`143`	`147`	`)`
`144`	`148`	`}`