[bugfix] preserve order in groupby (#3268)

mistercrunch · web-flow · commit 57421d14d081 · 2017-08-09T18:06:18.000-07:00
Recently in 4c3313b I introduced an issue where the order of groupby fields might change. This addresses this issue and will preserve ordering.
diff --git a/superset/viz.py b/superset/viz.py
@@ -112,10 +112,13 @@ def get_extra_filters(self):
     def query_obj(self):
         """Building a query object"""
         form_data = self.form_data
-        groupby = form_data.get("groupby") or []
+        gb = form_data.get("groupby") or []
         metrics = form_data.get("metrics") or []
         columns = form_data.get("columns") or []
-        groupby = list(set(groupby + columns))
+        groupby = []
+        for o in gb + columns:
+            if o not in groupby:
+                groupby.append(o)
 
         is_timeseries = self.is_timeseries
         if DTTM_ALIAS in groupby:
