feat: Adds a separator to Select All option (#22776)

michael-s-molina · web-flow · commit 1fe4a71f5be1 · 2023-01-19T12:22:57.000-05:00
diff --git a/superset-frontend/.storybook/preview.jsx b/superset-frontend/.storybook/preview.jsx
@@ -87,5 +87,5 @@ addParameters({
       ],
     },
   },
-  controls: { expanded: true },
+  controls: { expanded: true, sort: 'alpha' },
 });
diff --git a/superset-frontend/src/components/Select/Select.tsx b/superset-frontend/src/components/Select/Select.tsx
@@ -467,6 +467,7 @@ const Select = forwardRef(
           {selectAllEnabled && (
             <Option
               id="select-all"
+              className="select-all"
               key={SELECT_ALL_VALUE}
               value={SELECT_ALL_VALUE}
             >
diff --git a/superset-frontend/src/components/Select/styles.tsx b/superset-frontend/src/components/Select/styles.tsx
@@ -52,7 +52,9 @@ export const StyledSelect = styled(AntdSelect, {
     .ant-select-arrow .anticon:not(.ant-select-suffix) {
       pointer-events: none;
     }
-
+    .select-all {
+      border-bottom: 1px solid ${theme.colors.grayscale.light3};
+    }
     ${
       oneLine &&
       `

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,9 @@ export const StyledSelect = styled(AntdSelect, {`
`52`	`52`	`.ant-select-arrow .anticon:not(.ant-select-suffix) {`
`53`	`53`	`pointer-events: none;`
`54`	`54`	`}`
`55`		`-`
	`55`	`+ .select-all {`
	`56`	`+ border-bottom: 1px solid ${theme.colors.grayscale.light3};`
	`57`	`+ }`
`56`	`58`	`${`
`57`	`59`	`oneLine &&`
`58`	`60`	`