[Improve] Refactor update setting interface #3585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to improve-docker-email-setting # Conflicts: # streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/bean/SettingAlertEmailConfigParams.java # streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/bean/SettingDockerConfigParams.java # streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/controller/SettingController.java # streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/SettingService.java # streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/SettingServiceImpl.java # streampark-console/streampark-console-service/src/test/java/org/apache/streampark/console/core/bean/SettingAlertEmailConfigParamsTest.java # streampark-console/streampark-console-service/src/test/java/org/apache/streampark/console/core/bean/SettingDockerConfigParamsTest.java # streampark-console/streampark-console-service/src/test/java/org/apache/streampark/console/core/service/SettingServiceTest.java
zhengkezhou1
force-pushed
the
improve-docker-email-setting
branch
from
f19ec3e to
ea9c1c8
Compare
wolfboys
reviewed
Feb 27, 2024
| /* Docker namespace rules based on the format of the domain name */ | ||
| private static final String NAMESPACE_REGEX = "^(?!-)[a-zA-Z0-9-]{1,253}(?<!-)$"; | ||
|
|
||
| public static boolean verifyParams(SettingDockerConfigParams params) { |
Member
There was a problem hiding this comment.
Just send the request directly, connect to the target Docker instance, and perform the validation. 🤔
Member
|
I'll merge the PR first, and later I'll submit a PR to fix it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request
Issue Number: close #3578
Platforms such as Dcker Configuration and Alert Configuration lack parameter checks and are too arbitrary. Improve this by making the configurations for the different functions available as a complete form, so that they can be verified for completeness and compliance at submission time.
Brief change log
Verifying this change
This change added tests and can be verified as follows: