Repository navigation
[SPARK-59914][K8S] Make ExecutorResizePlugin skip executor pods with the placeholder EXECID label - #59175
Closed
dongjoon-hyun wants to merge 1 commit into
Closed
[SPARK-59914][K8S] Make ExecutorResizePlugin skip executor pods with the placeholder EXECID label#59175dongjoon-hyun wants to merge 1 commit into
ExecutorResizePlugin skip executor pods with the placeholder EXECID label#59175dongjoon-hyun wants to merge 1 commit into
Conversation
…h the placeholder `EXECID` label
Member
Author
|
cc @peter-toth |
Member
Author
|
Could you review this PR, @szehon-ho ? |
HyukjinKwon
approved these changes
Oct 1, 2026
Member
Author
|
Thank you, @HyukjinKwon ! |
dongjoon-hyun
added a commit
that referenced
this pull request
Oct 1, 2026
…h the placeholder `EXECID` label ### What changes were proposed in this pull request? This PR aims to make `ExecutorResizePlugin` skip executor pods whose `spark-exec-id` label is the placeholder `EXECID`, like `ExecutorPodsSnapshot` does. ### Why are the changes needed? `deployment` and `statefulset` pods allocators create executor pods with the `EXECID` label and patch the real executor ID later on a best-effort basis. Currently, `ExecutorResizePlugin` runs only with the `direct` pods allocator, so this is a defensive improvement. It keeps the placeholder out of the `cappedExecutors` keys and the logs. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs with the newly added test case. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Opus 5.5 Closes #59175 from dongjoon-hyun/SPARK-59914. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 6ed637f) Signed-off-by: Dongjoon Hyun <[email protected]>
Member
Author
Member
Author
Member
|
late lgtm |
Member
Author
|
Thank you, @szehon-ho , too! |
dongjoon-hyun
added a commit
that referenced
this pull request
Oct 1, 2026
…sizePlugin` ### What changes were proposed in this pull request? This PR aims to support `ExecutorResizePlugin` with the `deployment` pods allocator for Apache Spark 4.4.0 in addition to the default `direct` pods allocator. ### Why are the changes needed? [SPARK-56670](#55615) restricted `ExecutorResizePlugin` to the `direct` pods allocator because the higher-level controller's pod template is the source of truth for the other allocators with different mechanism. However, after SPARK-59914, Spark becomes capable of support `Deployment` because we never updates its pod template, and the `ReplicaSet` controller neither reverts in-place pod resizes nor rolls out a new revision for them. - #59175 ### Does this PR introduce _any_ user-facing change? Yes. In Apache Spark 4.2.0, `ExecutorResizePlugin` logs a warning and does not start with the `deployment` pods allocator. After this PR, it works with the `deployment` pods allocator. ### How was this patch tested? Pass the CIs with the updated test case. I also verified manually on K8s v1.37.0 that the executor pods of the `Deployment` are resized in place up to `spark.kubernetes.executor.resizeMaxMemory` without restarts, while the `Deployment` keeps its pod template and a single `ReplicaSet`. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Opus 5.5 Closes #59180 from dongjoon-hyun/dongjoon/executor-resize-plugin-deployment-0e6321. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
added a commit
that referenced
this pull request
Oct 1, 2026
…sizePlugin` ### What changes were proposed in this pull request? This PR aims to support `ExecutorResizePlugin` with the `deployment` pods allocator for Apache Spark 4.4.0 in addition to the default `direct` pods allocator. ### Why are the changes needed? [SPARK-56670](#55615) restricted `ExecutorResizePlugin` to the `direct` pods allocator because the higher-level controller's pod template is the source of truth for the other allocators with different mechanism. However, after SPARK-59914, Spark becomes capable of support `Deployment` because we never updates its pod template, and the `ReplicaSet` controller neither reverts in-place pod resizes nor rolls out a new revision for them. - #59175 ### Does this PR introduce _any_ user-facing change? Yes. In Apache Spark 4.2.0, `ExecutorResizePlugin` logs a warning and does not start with the `deployment` pods allocator. After this PR, it works with the `deployment` pods allocator. ### How was this patch tested? Pass the CIs with the updated test case. I also verified manually on K8s v1.37.0 that the executor pods of the `Deployment` are resized in place up to `spark.kubernetes.executor.resizeMaxMemory` without restarts, while the `Deployment` keeps its pod template and a single `ReplicaSet`. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Opus 5.5 Closes #59180 from dongjoon-hyun/dongjoon/executor-resize-plugin-deployment-0e6321. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 913175e) Signed-off-by: Dongjoon Hyun <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to make
ExecutorResizePluginskip executor pods whosespark-exec-idlabel is the placeholderEXECID, likeExecutorPodsSnapshotdoes.Why are the changes needed?
deploymentandstatefulsetpods allocators create executor pods with theEXECIDlabel and patch the real executor ID later on a best-effort basis. Currently,ExecutorResizePluginruns only with thedirectpods allocator, so this is a defensive improvement. It keeps the placeholder out of thecappedExecutorskeys and the logs.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs with the newly added test case.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 5.5