Repository navigation
[SPARK-56702][K8S] Restrict ExecutorPVCResizePlugin to direct pods allocator - #55652
Closed
dongjoon-hyun wants to merge 1 commit into
Closed
dongjoon-hyun wants to merge 1 commit into
dongjoon-hyun wants to merge 1 commit into
Conversation
dongjoon-hyun
changed the title
ExecutorPVCResizePlugin to direct pods allocatorExecutorPVCResizePlugin to direct pods allocator
Member
Author
|
All tests passed. 
|
Member
Author
|
Could you review this PR when you have some time, @huaxingao ? |
Member
Author
|
Thank you so much, @huaxingao ~ |
Member
Author
|
Merged to master for Apache Spark 4.2.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR restricts
ExecutorPVCResizePluginto thedirectpods allocator. Whenspark.kubernetes.allocation.pods.allocatoris notdirect,init()logs a warning and returns early.Why are the changes needed?
ExecutorPVCResizePluginpatches individual executor PVCs directly. This only works when Spark owns each pod and its PVCs (directallocator). Forstatefulsetanddeploymentallocators, PVCs are governed by the controller'svolumeClaimTemplates, so direct patches conflict with the controller.This mirrors SPARK-56670, which restricted the sibling
ExecutorResizePluginfor the same reason.ExecutorResizePlugintodirectpods allocator #55615Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs with new unit tests.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.7)