[SPARK-54110][Geo][SQL] Introduce type encoders for Geography and Geometry types #52813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uros-db
commented
Oct 31, 2025
Contributor
Author
uros-db
left a comment
uros-db
left a comment
There was a problem hiding this comment.
@cloud-fan Please review.
cloud-fan
reviewed
Oct 31, 2025
sql/api/src/main/scala/org/apache/spark/sql/types/GeographyType.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Oct 31, 2025
sql/api/src/main/scala/org/apache/spark/sql/types/GeographyType.scala
Outdated
Show resolved
Hide resolved
cloud-fan
approved these changes
Nov 3, 2025
Contributor
|
thanks, merging to master/4.1! |
cloud-fan
pushed a commit
that referenced
this pull request
Nov 3, 2025
…metry types ### What changes were proposed in this pull request? This PR introduces type encoders for `Geography` and `Geometry`. Note that the server-side geospatial classes have already been introduced as part of: #52737; while client-side geospatial classes in external API have subsequently been introduced as part of: #52804. ### Why are the changes needed? These encoders are used to translate between (server) Spark Catalyst types and (client) Java/Scala types. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Added new Scala unit test suites for data frames: - `GeographyDataFrameSuite` - `GeometryDataFrameSuite` Also, added appropriate test cases to: - `RowSuite` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #52813 from uros-db/geo-expression-encoders. Authored-by: Uros Bojanic <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit 2f94313) Signed-off-by: Wenchen Fan <[email protected]>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Nov 8, 2025
…es in PySpark ### What changes were proposed in this pull request? This PR introduces type encoders for `Geography` and `Geometry` in PySpark. Note that Scala-side encoders for geospatial types were added in: #52813. ### Why are the changes needed? Expanding client support for geospatial types in PySpark API. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? New PySpark unit tests: - `test_types` - `test_parity_types` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #52861 from uros-db/geo-pyspark-encoders. Authored-by: Uros Bojanic <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Nov 8, 2025
…es in PySpark ### What changes were proposed in this pull request? This PR introduces type encoders for `Geography` and `Geometry` in PySpark. Note that Scala-side encoders for geospatial types were added in: #52813. ### Why are the changes needed? Expanding client support for geospatial types in PySpark API. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? New PySpark unit tests: - `test_types` - `test_parity_types` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #52861 from uros-db/geo-pyspark-encoders. Authored-by: Uros Bojanic <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit d304a03) Signed-off-by: Dongjoon Hyun <[email protected]>
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 22, 2025
…es in PySpark ### What changes were proposed in this pull request? This PR introduces type encoders for `Geography` and `Geometry` in PySpark. Note that Scala-side encoders for geospatial types were added in: apache#52813. ### Why are the changes needed? Expanding client support for geospatial types in PySpark API. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? New PySpark unit tests: - `test_types` - `test_parity_types` ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52861 from uros-db/geo-pyspark-encoders. Authored-by: Uros Bojanic <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
…metry types ### What changes were proposed in this pull request? This PR introduces type encoders for `Geography` and `Geometry`. Note that the server-side geospatial classes have already been introduced as part of: apache#52737; while client-side geospatial classes in external API have subsequently been introduced as part of: apache#52804. ### Why are the changes needed? These encoders are used to translate between (server) Spark Catalyst types and (client) Java/Scala types. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Added new Scala unit test suites for data frames: - `GeographyDataFrameSuite` - `GeometryDataFrameSuite` Also, added appropriate test cases to: - `RowSuite` ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52813 from uros-db/geo-expression-encoders. Authored-by: Uros Bojanic <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
…es in PySpark ### What changes were proposed in this pull request? This PR introduces type encoders for `Geography` and `Geometry` in PySpark. Note that Scala-side encoders for geospatial types were added in: apache#52813. ### Why are the changes needed? Expanding client support for geospatial types in PySpark API. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? New PySpark unit tests: - `test_types` - `test_parity_types` ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52861 from uros-db/geo-pyspark-encoders. Authored-by: Uros Bojanic <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR introduces type encoders for
GeographyandGeometry.Note that the server-side geospatial classes have already been introduced as part of: #52737; while client-side geospatial classes in external API have subsequently been introduced as part of: #52804.
Why are the changes needed?
These encoders are used to translate between (server) Spark Catalyst types and (client) Java/Scala types.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added new Scala unit test suites for data frames:
GeographyDataFrameSuiteGeometryDataFrameSuiteAlso, added appropriate test cases to:
RowSuiteWas this patch authored or co-authored using generative AI tooling?
No.