[SPARK-54104][Geo][SQL] Disallow casting geospatial types to/from other data types #52806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uros-db
commented
Oct 31, 2025
Contributor
Author
uros-db
left a comment
uros-db
left a comment
There was a problem hiding this comment.
@cloud-fan @zhengruifeng @mkaravel @szehon-ho Please review.
cloud-fan
reviewed
Oct 31, 2025
sql/core/src/test/resources/sql-tests/analyzer-results/nonansi/st-functions.sql.out
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Oct 31, 2025
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastWithAnsiOnSuite.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Oct 31, 2025
...catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/st/STExpressionUtils.scala
Show resolved
Hide resolved
cloud-fan
approved these changes
Oct 31, 2025
Contributor
|
thanks, merging to master! |
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
…er data types ### What changes were proposed in this pull request? This PR disallows casting `GEOGRAPHY` and `GEOMETRY` to/from other data types in the system (such as `BOOLEAN`, `BINARY`, `STRING`, and others). Note that these types were recently introduced as part of: apache#52491. ### Why are the changes needed? `GeographyType` and `GeometryType` are not interoperable with any other non-geospatial data types, so we need to forbid such casts explicitly in order to avoid unexpected failures. ### Does this PR introduce _any_ user-facing change? Yes, casts are disallowed for newly introduced geospatial types. ### How was this patch tested? Added new unit tests to verify the expected behaviour: - `CastWithAnsiOffSuite` - `CastWithAnsiOnSuite` Added new appropriate end-to-end SQL tests: - `st-functions` ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52806 from uros-db/geo-cast-disallow. Authored-by: Uros Bojanic <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR disallows casting
GEOGRAPHYandGEOMETRYto/from other data types in the system (such asBOOLEAN,BINARY,STRING, and others). Note that these types were recently introduced as part of: #52491.Why are the changes needed?
GeographyTypeandGeometryTypeare not interoperable with any other non-geospatial data types, so we need to forbid such casts explicitly in order to avoid unexpected failures.Does this PR introduce any user-facing change?
Yes, casts are disallowed for newly introduced geospatial types.
How was this patch tested?
Added new unit tests to verify the expected behaviour:
CastWithAnsiOffSuiteCastWithAnsiOnSuiteAdded new appropriate end-to-end SQL tests:
st-functionsWas this patch authored or co-authored using generative AI tooling?
No.