[SPARK-52962][SQL] BroadcastExchangeExec should not reset metrics #51673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
changed the title
Member
Author
|
Merged to master. Thanks @peter-toth |
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @viirya and Peter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch implements a no-op
resetMetricsmethod forBroadcastExchangeExec.Why are the changes needed?
This was found during debugging test failures at #51623.
A materialized broadcast exchange (i.e.,
BroadcastExchangeExec) operator will be trimmed by AQE's empty relation propagation rule to an empty local relation. That's is because its metrics was reset.BroadcastExchangeExecafter materialized won't be materialized again, so its metrics won't be updated again.It is weird and inconsistent that a materialized broadcast exchange still hold broadcast value but its metrics are reset.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit test
Was this patch authored or co-authored using generative AI tooling?
No