Repository navigation
[SPARK-51079] Added constructor for ArrowSerializer for backward compatibility. - #50513
Closed
haiyangsun-db wants to merge 1 commit into
Closed
haiyangsun-db wants to merge 1 commit into
haiyangsun-db wants to merge 1 commit into
Conversation
haiyangsun-db
changed the title
haiyangsun-db
marked this pull request as ready for review
April 4, 2025 10:07
HyukjinKwon
approved these changes
Apr 4, 2025
HyukjinKwon
pushed a commit
that referenced
this pull request
Apr 7, 2025
…atibility ### What changes were proposed in this pull request? Previously, [PR](#49790) extends ArrowSerializer class to support large variable types in pandas UDF. This PR makes it more backward-compatible by adding a new constructor for cases where the flag for large variable is irrelevant (default to false). ### Why are the changes needed? To achieve versionless in spark connect, we need to be careful about changing a client API in Scala. For example, the change of an interface like this could affect Scala UDF referring to this class (as it is part of the spark connect client package) but running with an older spark connect client. ### How was this patch tested? N/A. It's a new constructor. Closes #50513 from haiyangsun-db/SPARK-51079. Authored-by: Haiyang Sun <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]> (cherry picked from commit 75d80c7) Signed-off-by: Hyukjin Kwon <[email protected]>
Member
|
Merged to master and branch-4.0. |
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 14, 2025
…atibility ### What changes were proposed in this pull request? Previously, [PR](apache#49790) extends ArrowSerializer class to support large variable types in pandas UDF. This PR makes it more backward-compatible by adding a new constructor for cases where the flag for large variable is irrelevant (default to false). ### Why are the changes needed? To achieve versionless in spark connect, we need to be careful about changing a client API in Scala. For example, the change of an interface like this could affect Scala UDF referring to this class (as it is part of the spark connect client package) but running with an older spark connect client. ### How was this patch tested? N/A. It's a new constructor. Closes apache#50513 from haiyangsun-db/SPARK-51079. Authored-by: Haiyang Sun <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]> (cherry picked from commit 0c50c2c) Signed-off-by: Hyukjin Kwon <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Previously, PR extends ArrowSerializer class to support large variable types in pandas UDF. This PR makes it more backward-compatible by adding a new constructor for cases where the flag for large variable is irrelevant (default to false).
Why are the changes needed?
To achieve versionless in spark connect, we need to be careful about changing a client API in Scala. For example, the change of an interface like this could affect Scala UDF referring to this class (as it is part of the spark connect client package) but running with an older spark connect client.
How was this patch tested?
N/A. It's a new constructor.