[SPARK-51171][BUILD] Upgrade checkstyle to 10.21.2
#49899
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
approved these changes
Feb 12, 2025
LuciferYang
approved these changes
Feb 12, 2025
yaooqinn
approved these changes
Feb 12, 2025
|
Merged to master. Thank you, @wayneguow and all! |
kazemaksOG
pushed a commit
to kazemaksOG/spark-custom-scheduler
that referenced
this pull request
Mar 27, 2025
### What changes were proposed in this pull request? This PR aims to upgrade `checkstyle` from 10.20.2 to 10.21.2. ### Why are the changes needed? To pick up bug fixes: - checkstyle-10.21.2 checkstyle/checkstyle#15939 - lineWrappingIndentation falsely detects incorrect indentation for text blocks checkstyle/checkstyle#16101 - ignoreFieldDeclaration property should have the highest priority in MagicNumberCheck - checkstyle-10.21.1 checkstyle/checkstyle#11374 - UnusedLocalVariable: False Positive when inner class has same field as variable Full release notes: - https://github.com/checkstyle/checkstyle/releases/tag/checkstyle-10.21.2 - https://github.com/checkstyle/checkstyle/releases/tag/checkstyle-10.21.1 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manually by: ``` bash ./dev/lint-java ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#49899 from wayneguow/checkstyle. Authored-by: Wei Guo <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to upgrade
checkstylefrom 10.20.2 to 10.21.2.Why are the changes needed?
To pick up bug fixes:
lineWrappingIndentationfalsely detects incorrect indentation for text blocks checkstyle/checkstyle#15939 - lineWrappingIndentation falsely detects incorrect indentation for text blocksignoreFieldDeclarationproperty should have the highest priority in MagicNumberCheck checkstyle/checkstyle#16101 - ignoreFieldDeclaration property should have the highest priority in MagicNumberCheckUnusedLocalVariable: False Positive when inner class has same field as variable checkstyle/checkstyle#11374 - UnusedLocalVariable: False Positive when inner class has same field as variable
Full release notes:
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually by:
Was this patch authored or co-authored using generative AI tooling?
No.