Skip to content

SPARK-4044 [CORE] Thriftserver fails to start when JAVA_HOME points to JRE instead of JDK #4981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
srowen wants to merge 1 commit into from
Closed

SPARK-4044 [CORE] Thriftserver fails to start when JAVA_HOME points to JRE instead of JDK #4981

srowen wants to merge 1 commit into from

Conversation

@srowen
Copy link
Member

@srowen srowen commented Mar 11, 2015

Don't use JAR_CMD unless present in archive check. Add datanucleus always if present, to avoid needing a check involving JAR_CMD.

Follow up to #4873 for branch 1.3.

@srowen
Don't use JAR_CMD unless present in archive check. Add datanucleus al…
3aafc76 
…ways if present, to avoid needing a check involving JAR_CMD
@SparkQA
Copy link

SparkQA commented Mar 11, 2015

Test build #28474 has started for PR 4981 at commit 3aafc76.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Mar 11, 2015

Test build #28474 has finished for PR 4981 at commit 3aafc76.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Mar 11, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28474/
Test PASSed.

@vanzin
Copy link
Contributor

vanzin commented Mar 11, 2015

LGTM.

asfgit pushed a commit that referenced this pull request Mar 13, 2015
@srowen
SPARK-4044 [CORE] Thriftserver fails to start when JAVA_HOME points t…
4aa4132 
…o JRE instead of JDK

Don't use JAR_CMD unless present in archive check. Add datanucleus always if present, to avoid needing a check involving JAR_CMD.

Follow up to #4873 for branch 1.3.

Author: Sean Owen <[email protected]>

Closes #4981 from srowen/SPARK-4044.2 and squashes the following commits:

3aafc76 [Sean Owen] Don't use JAR_CMD unless present in archive check. Add datanucleus always if present, to avoid needing a check involving JAR_CMD
@srowen srowen closed this Mar 13, 2015
@srowen srowen deleted the SPARK-4044.2 branch March 13, 2015 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@srowen @SparkQA @AmplabJenkins @vanzin