[SPARK-50218][BUILD] Upgrade checkstyle to 10.20.0 #48752
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
approved these changes
Nov 4, 2024
|
Merged to master for Apache Spark 4.0.0 on February 2025. |
LuciferYang
reviewed
Dec 3, 2024
| @@ -19,7 +19,7 @@ addSbtPlugin("software.purpledragon" % "sbt-checkstyle-plugin" % "4.0.1") | |||
|
|
|||
| // If you are changing the dependency setting for checkstyle plugin, | |||
| // please check pom.xml in the root of the source tree too. | |||
| libraryDependencies += "com.puppycrawl.tools" % "checkstyle" % "10.17.0" | |||
| libraryDependencies += "com.puppycrawl.tools" % "checkstyle" % "10.20.0" | |||
|
|
|||
| // checkstyle uses guava 33.1.0-jre. | |||
| libraryDependencies += "com.google.guava" % "guava" % "33.1.0-jre" | |||
There was a problem hiding this comment.
@HyukjinKwon Would like to confirm if "com.puppycrawl.tools" % "checkstyle" % "10.20.0" still depends on guava 33.1.0-jre?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to upgrade checkstyle to 10.20.0
Why are the changes needed?
To pick up bug fixes made, e.g., checkstyle/checkstyle#15687
See also https://github.com/checkstyle/checkstyle/releases
Does this PR introduce any user-facing change?
No, dev-only.
How was this patch tested?
Manually by:
Was this patch authored or co-authored using generative AI tooling?
No.