Repository navigation
[SPARK-46229][PYTHON][CONNECT][FOLLOW-UP] Remove unnecessary Python version check lower than 3.8 - #44168
Closed
HyukjinKwon wants to merge 2 commits into
Closed
[SPARK-46229][PYTHON][CONNECT][FOLLOW-UP] Remove unnecessary Python version check lower than 3.8#44168HyukjinKwon wants to merge 2 commits into
HyukjinKwon wants to merge 2 commits into
Conversation
ueshin
reviewed
Dec 4, 2023
ueshin
approved these changes
Dec 5, 2023
Member
There was a problem hiding this comment.
Shall we proceed this as a new independent PR instead of a follow-up?
$ git grep 'sys.version_info' | grep '(3, 8)'
python/pyspark/cloudpickle/compat.py:if sys.version_info < (3, 8):
python/pyspark/pandas/tests/computation/test_apply_func.py: if sys.version_info >= (3, 8):
python/pyspark/pandas/tests/test_typedef.py: if sys.version_info >= (3, 8):
python/pyspark/pandas/typedef/typehints.py: if sys.version_info >= (3, 8):
python/pyspark/sql/connect/_typing.py:if sys.version_info >= (3, 8):
python/pyspark/sql/connect/proto/catalog_pb2.pyi:if sys.version_info >= (3, 8):
python/pyspark/sql/connect/proto/common_pb2.pyi:if sys.version_info >= (3, 8):
python/pyspark/sql/connect/proto/example_plugins_pb2.pyi:if sys.version_info >= (3, 8):
python/pyspark/sql/connect/proto/types_pb2.pyi:if sys.version_info >= (3, 8):
Member
Author
|
Yup, I will double check all the Python version ones soon. |
Member
Author
|
Merged to master. |
asl3
pushed a commit
to asl3/spark
that referenced
this pull request
Dec 5, 2023
…ersion check lower than 3.8 ### What changes were proposed in this pull request? This PR addresses the review comment apache#44146 (comment). ### Why are the changes needed? We don't support Python lower than 3.8 so we can remove that if-else on Python version. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests via CI. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#44168 from HyukjinKwon/SPARK-46229-followup. Lead-authored-by: Hyukjin Kwon <[email protected]> Co-authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
dbatomic
pushed a commit
to dbatomic/spark
that referenced
this pull request
Dec 11, 2023
…ersion check lower than 3.8 ### What changes were proposed in this pull request? This PR addresses the review comment apache#44146 (comment). ### Why are the changes needed? We don't support Python lower than 3.8 so we can remove that if-else on Python version. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests via CI. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#44168 from HyukjinKwon/SPARK-46229-followup. Lead-authored-by: Hyukjin Kwon <[email protected]> Co-authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR addresses the review comment #44146 (comment).
Why are the changes needed?
We don't support Python lower than 3.8 so we can remove that if-else on Python version.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests via CI.
Was this patch authored or co-authored using generative AI tooling?
No.