Repository navigation
[SPARK-46229][PYTHON][CONNECT] Add applyInArrow to groupBy and cogroup in Spark Connect - #44146
Closed
HyukjinKwon wants to merge 3 commits into
Closed
HyukjinKwon wants to merge 3 commits into
HyukjinKwon wants to merge 3 commits into
Conversation
HyukjinKwon
marked this pull request as draft
December 4, 2023 02:50
HyukjinKwon
force-pushed
the
connect-arrow-api
branch
from
December 4, 2023 02:53
2f7b757 to
d148e9a
Compare
Contributor
|
LGTM pending CI |
HyukjinKwon
force-pushed
the
connect-arrow-api
branch
from
December 4, 2023 03:26
d148e9a to
1c5c54f
Compare
HyukjinKwon
changed the title
HyukjinKwon
force-pushed
the
connect-arrow-api
branch
from
December 4, 2023 05:13
03c8537 to
511213e
Compare
HyukjinKwon
marked this pull request as ready for review
December 4, 2023 05:13
Member
Author
|
I manually tested the latest changes. Merged to master. |
ueshin
reviewed
Dec 4, 2023
|
|
||
| if sys.version_info >= (3, 8): | ||
| from typing import Protocol | ||
| from typing import Protocol, Tuple |
Member
There was a problem hiding this comment.
nit: This seems to be no-op as Tuple will be overwritten by the following imports?
Member
There was a problem hiding this comment.
btw, we can remove if sys.version_info >= (3, 8): and the following part as we already dropped Python<3.8?
HyukjinKwon
added a commit
that referenced
this pull request
Dec 5, 2023
…ersion check lower than 3.8 ### What changes were proposed in this pull request? This PR addresses the review comment #44146 (comment). ### Why are the changes needed? We don't support Python lower than 3.8 so we can remove that if-else on Python version. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests via CI. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #44168 from HyukjinKwon/SPARK-46229-followup. Lead-authored-by: Hyukjin Kwon <[email protected]> Co-authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
asl3
pushed a commit
to asl3/spark
that referenced
this pull request
Dec 5, 2023
…p in Spark Connect ### What changes were proposed in this pull request? This PR implements Spark Connect version of apache#38624. ### Why are the changes needed? For feature parity. ### Does this PR introduce _any_ user-facing change? Yes, it adds a new API for Python Spark Connect client. ### How was this patch tested? Reused unittest and doctests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#44146 from HyukjinKwon/connect-arrow-api. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
asl3
pushed a commit
to asl3/spark
that referenced
this pull request
Dec 5, 2023
…ersion check lower than 3.8 ### What changes were proposed in this pull request? This PR addresses the review comment apache#44146 (comment). ### Why are the changes needed? We don't support Python lower than 3.8 so we can remove that if-else on Python version. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests via CI. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#44168 from HyukjinKwon/SPARK-46229-followup. Lead-authored-by: Hyukjin Kwon <[email protected]> Co-authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
dbatomic
pushed a commit
to dbatomic/spark
that referenced
this pull request
Dec 11, 2023
…p in Spark Connect ### What changes were proposed in this pull request? This PR implements Spark Connect version of apache#38624. ### Why are the changes needed? For feature parity. ### Does this PR introduce _any_ user-facing change? Yes, it adds a new API for Python Spark Connect client. ### How was this patch tested? Reused unittest and doctests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#44146 from HyukjinKwon/connect-arrow-api. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
dbatomic
pushed a commit
to dbatomic/spark
that referenced
this pull request
Dec 11, 2023
…ersion check lower than 3.8 ### What changes were proposed in this pull request? This PR addresses the review comment apache#44146 (comment). ### Why are the changes needed? We don't support Python lower than 3.8 so we can remove that if-else on Python version. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests via CI. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#44168 from HyukjinKwon/SPARK-46229-followup. Lead-authored-by: Hyukjin Kwon <[email protected]> Co-authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR implements Spark Connect version of #38624.
Why are the changes needed?
For feature parity.
Does this PR introduce any user-facing change?
Yes, it adds a new API for Python Spark Connect client.
How was this patch tested?
Reused unittest and doctests.
Was this patch authored or co-authored using generative AI tooling?
No.