[SPARK-44553][BUILD][3.4] Ignoring connect-check-protos logic in GA testing
#42166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
approved these changes
Jul 26, 2023
Contributor
LuciferYang
left a comment
LuciferYang
left a comment
There was a problem hiding this comment.
+1, LGTM
cc @HyukjinKwon FYI
HyukjinKwon
approved these changes
Jul 26, 2023
Contributor
|
I think this PR and #42172 needs each other :) |
zhengruifeng
pushed a commit
that referenced
this pull request
Jul 27, 2023
… testing ### What changes were proposed in this pull request? The pr aims to ignoring `connect-check-protos` logic in GA testing for branch-3.4. ### Why are the changes needed? Make GA happy. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. Closes #42166 from panbingkun/branch-3.4_SPARK-44553. Authored-by: panbingkun <[email protected]> Signed-off-by: Ruifeng Zheng <[email protected]>
Contributor
|
LGTM, merged to branch-3.4 |
viirya
pushed a commit
to viirya/spark-1
that referenced
this pull request
Oct 19, 2023
… testing ### What changes were proposed in this pull request? The pr aims to ignoring `connect-check-protos` logic in GA testing for branch-3.4. ### Why are the changes needed? Make GA happy. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. Closes apache#42166 from panbingkun/branch-3.4_SPARK-44553. Authored-by: panbingkun <[email protected]> Signed-off-by: Ruifeng Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to ignoring
connect-check-protoslogic in GA testing for branch-3.4.Why are the changes needed?
Make GA happy.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.