[SPARK-44494][INFRA] Use minikube v1.30.1 for k8s-integration-tests
#42091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
commented
Jul 20, 2023
| # See more in "Installation" https://minikube.sigs.k8s.io/docs/start/ | ||
| curl -LO https://storage.googleapis.com/minikube/releases/latest/minikube-linux-amd64 | ||
| # curl -LO https://storage.googleapis.com/minikube/releases/latest/minikube-linux-amd64 | ||
| curl -LO https://storage.googleapis.com/minikube/releases/v1.30.1/minikube-linux-amd64 |
Contributor
Author
There was a problem hiding this comment.
The latest version is v1.31.0 and the k8s-it failed last 2 days
Contributor
Author
|
@Yikun @HyukjinKwon I haven't found the root cause of the failure yet. This pr is trying to restore GA using last successful minikube version first. WDYT? |
Member
|
Yeah, if it fixes the build it's good |
Contributor
Author
seems ok, let me pr description and leave a TODO |
LuciferYang
changed the title
k8s-integration-tests
LuciferYang
changed the title
k8s-integration-testsminikube v1.30.1 for k8s-integration-tests
panbingkun
approved these changes
Jul 20, 2023
dongjoon-hyun
approved these changes
Jul 20, 2023
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you for recovering CI, @LuciferYang .
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jul 20, 2023
### What changes were proposed in this pull request? This pr change to use `minikube` v1.30.1 for `k8s-integration-tests` on GitHub Action, this is a temporary solution. This PR also leaves a TODO: - SPARK-44495: Resume to use the latest minikube for `k8s-integration-tests` on GitHub Action ### Why are the changes needed? Restore `k8s-integration-tests` GA testing ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - `k8s-integration-tests` test pass on GitHub Action Closes #42091 from LuciferYang/SPARK-44494. Authored-by: yangjie01 <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 57b985c) Signed-off-by: Dongjoon Hyun <[email protected]>
Member
|
Merged to master/3.5. If we need this to branch-3.4 and older, please feel free to backport it, @LuciferYang . |
Contributor
Author
|
@dongjoon-hyun OK ~ |
LuciferYang
added a commit
to LuciferYang/spark
that referenced
this pull request
Jul 26, 2023
### What changes were proposed in this pull request? This pr change to use `minikube` v1.30.1 for `k8s-integration-tests` on GitHub Action, this is a temporary solution. This PR also leaves a TODO: - SPARK-44495: Resume to use the latest minikube for `k8s-integration-tests` on GitHub Action ### Why are the changes needed? Restore `k8s-integration-tests` GA testing ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - `k8s-integration-tests` test pass on GitHub Action Closes apache#42091 from LuciferYang/SPARK-44494. Authored-by: yangjie01 <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr change to use
minikubev1.30.1 fork8s-integration-testson GitHub Action, this is a temporary solution.This PR also leaves a TODO:
k8s-integration-testson GitHub ActionWhy are the changes needed?
Restore
k8s-integration-testsGA testingDoes this PR introduce any user-facing change?
No
How was this patch tested?
k8s-integration-teststest pass on GitHub Action