[SPARK-42101][SQL][FOLLOWUP] Make QueryStageExec.resultOption and isMeterialized consistent #40522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
commented
Mar 22, 2023
Contributor
Author
There was a problem hiding this comment.
a small cleanup. We don't need to run any rules for InMemoryTableScanExec as it's a leaf node and supports both columnar and row-based output.
Contributor
Author
|
cc @ulysses-you |
Contributor
|
lgtm |
yaooqinn
approved these changes
Mar 24, 2023
Contributor
Author
|
thanks for review, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a followup of #39624 .
QueryStageExec.isMeterializedshould only return true ifresultOptionis assigned. It can be a potential bug to have this inconsistency.Why are the changes needed?
fix potential bug
Does this PR introduce any user-facing change?
no
How was this patch tested?
existing tests