[SPARK-42089][CONNECT][PYTHON] Fix variable name issues in nested lambda functions #39619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
force-pushed
the
connect_fix_nested_lambda
branch
from
ac2814d to
767498b
Compare
Contributor
Author
cloud-fan
approved these changes
Jan 17, 2023
HyukjinKwon
approved these changes
Jan 17, 2023
Contributor
Author
|
thanks for the reviews, merged into master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
1, #39068 reused the
UnresolvedAttributefor theUnresolvedNamedLambdaVariable, but thenColumn('x')andUnresolvedNamedLambdaVariable('x')are mixed inlambda x: x + cdf.x(since we usex/y/zas augment names); this PR adds theUnresolvedNamedLambdaVariableback to distinguish betweenColumn('x')andUnresolvedNamedLambdaVariable('x');2, the
refreshVarNamelogic in PySpark was added in #32523 to address similar issue in PySpark's Lambda Function, this PR adds a similar function in the Python Client to avoid rewriting the function expression in the server side, which is unnecessary and prone to error .Why are the changes needed?
before this PR, the nested lambda function doesn't work properly
Does this PR introduce any user-facing change?
no
How was this patch tested?
enabled UT and added UT