[SPARK-38489][SQL] Aggregate.groupOnly support foldable expressions #35795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
approved these changes
Mar 10, 2022
Contributor
cloud-fan
left a comment
cloud-fan
left a comment
There was a problem hiding this comment.
I checked all the caller sides of groupOnly, all look fine
Contributor
|
|
Member
Author
|
Fixed it. |
Contributor
|
thanks, merging to master! |
wangyum
added a commit
that referenced
this pull request
May 26, 2023
…tributes (#884) * Remove the aggregation from left semi/anti join if the same aggregation has already been done on left side * Add more test * grouping -> groupingExps * Add DistinctAttributesVisitor * Fix test name * Improve DistinctAttributesVisitor * Fix test. * DistinctKeyVisitor * Address comments * Fix scala 2.13 * Address comments * Address all comments * Address all comments * fix * fix test * [SPARK-38489][SQL] Aggregate.groupOnly support foldable expressions ### What changes were proposed in this pull request? This pr makes `Aggregate.groupOnly` support foldable expressions. ### Why are the changes needed? Improve query performance. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Unit test. Closes #35795 from wangyum/SPARK-38489. Authored-by: Yuming Wang <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit bcf7849) * Remove * fix * Update DistinctKeyVisitor.scala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr makes
Aggregate.groupOnlysupport foldable expressions.Why are the changes needed?
Improve query performance.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit test.