[SPARK-37727][SQL][TESTS][FOLLOW-UP] Add test cases for logs in SparkSession.builder.getOrCreate #35048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @cloud-fan, @AngersZhuuuu @yaooqinn FYI |
yaooqinn
reviewed
Dec 29, 2021
sql/core/src/test/scala/org/apache/spark/sql/SparkSessionBuilderSuite.scala
Outdated
Show resolved
Hide resolved
yaooqinn
reviewed
Dec 29, 2021
sql/core/src/test/scala/org/apache/spark/sql/SparkSessionBuilderSuite.scala
Outdated
Show resolved
Hide resolved
yaooqinn
reviewed
Dec 29, 2021
sql/core/src/test/scala/org/apache/spark/sql/SparkSessionBuilderSuite.scala
Outdated
Show resolved
Hide resolved
yaooqinn
reviewed
Dec 29, 2021
sql/core/src/test/scala/org/apache/spark/sql/SparkSessionBuilderSuite.scala
Outdated
Show resolved
Hide resolved
yaooqinn
reviewed
Dec 29, 2021
sql/core/src/test/scala/org/apache/spark/sql/SparkSessionBuilderSuite.scala
Outdated
Show resolved
Hide resolved
yaooqinn
approved these changes
Dec 29, 2021
Member
|
+1，LGTM |
dongjoon-hyun
approved these changes
Dec 29, 2021
cloud-fan
approved these changes
Dec 29, 2021
Member
Author
|
Wait .. the tests pass in IDE but fails in SBT shall command. Let me investigate this a bit more. |
HyukjinKwon
commented
Dec 29, 2021
| if (level.isDefined) { | ||
| logger.setLevel(level.get) | ||
| logger.get().setLevel(level.get) | ||
| LogManager.getContext(false).asInstanceOf[LoggerContext].updateLoggers() |
Member
Author
Member
Author
There was a problem hiding this comment.
I think the issue is the same. Once the log level is set, it doesn't get changed. That's why it passed in IDE when I run it individually, and it fails when I run them in batch via SBT.
Member
Author
There was a problem hiding this comment.
I don't mind making this in a separate PR if you guys feel that's better.
Member
There was a problem hiding this comment.
lgtm. I thought we should update the loggers here too. I actually was wondering if this should be do the same, but as no test failure happens I thought it maybe fine. :)
viirya
approved these changes
Dec 29, 2021
Member
Author
|
Merged to master! |
asiunov
pushed a commit
to ascend-io/spark
that referenced
this pull request
Aug 25, 2022
…Session.builder.getOrCreate ### What changes were proposed in this pull request? This PR adds some test cases for apache#35001. Test cases were not added because there are related bugs but they are fixed now. ### Why are the changes needed? To avoid regressions. ### Does this PR introduce _any_ user-facing change? No, dev-only. ### How was this patch tested? This PR adds test cases that were manually tested in apache#35001. Closes apache#35048 from HyukjinKwon/SPARK-37727-followup. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds some test cases for #35001. Test cases were not added because there are related bugs but they are fixed now.
Why are the changes needed?
To avoid regressions.
Does this PR introduce any user-facing change?
No, dev-only.
How was this patch tested?
This PR adds test cases that were manually tested in #35001.