[SPARK-32577][SQL][TEST][FOLLOWUP] Fix the config value of shuffled hash join for all other test queries#33249
Closed
c21 wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-32577][SQL][TEST][FOLLOWUP] Fix the config value of shuffled hash join for all other test queries#33249c21 wants to merge 1 commit intoapache:masterfrom
c21 wants to merge 1 commit intoapache:masterfrom
Conversation
HyukjinKwon
approved these changes
Jul 7, 2021
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Test build #140767 has finished for PR 33249 at commit
|
Member
|
Merged to master and branch-3.2. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Jul 8, 2021
…ash join for all other test queries ### What changes were proposed in this pull request? This is the followup from #33236 (comment), where we are fixing the config value of shuffled hash join, for all other test queries. Found all configs by searching in https://github.com/apache/spark/search?q=spark.sql.join.preferSortMergeJoin . ### Why are the changes needed? Fix test to have better test coverage. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests. Closes #33249 from c21/join-test. Authored-by: Cheng Su <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]> (cherry picked from commit 23943e5) Signed-off-by: Hyukjin Kwon <[email protected]>
Contributor
Author
|
Thank you @HyukjinKwon for review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is the followup from #33236 (comment), where we are fixing the config value of shuffled hash join, for all other test queries. Found all configs by searching in https://github.com/apache/spark/search?q=spark.sql.join.preferSortMergeJoin .
Why are the changes needed?
Fix test to have better test coverage.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.