[SPARK-34787] Option variable in Spark historyServer log should be displayed as actual value instead of Some(XX) #31882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
core/src/main/scala/org/apache/spark/deploy/history/ApplicationCache.scala
Outdated
Show resolved
Hide resolved
echohlne
changed the title
dongjoon-hyun
requested changes
Mar 23, 2021
Member
There was a problem hiding this comment.
Although this is a log message, we had better be consistent. Removing trailing / usually causes a redundant redirection like SPARK-34635.
$ curl --head http://localhost:18080/history/spark-7244d6f5b2774ba18d31d9149ef22100/jobs
HTTP/1.1 302 Found
Date: Tue, 23 Mar 2021 16:21:51 GMT
Location: http://localhost:18080/history/spark-7244d6f5b2774ba18d31d9149ef22100/jobs/
Content-Length: 0
Server: Jetty(9.4.36.v20210114)
Contributor
Author
|
@dongjoon-hyun This issue has been blocked for a while, could you please help to review it , thanks a lot! |
Contributor
Author
|
@dongjoon-hyun redirect to #32189 , the branch in this pr was too old, sorry. |
Member
|
No problem. Thank you for opening a new one. I'll review there, @Kyoty . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make the attemptId in the log of historyServer to be more easily to read.
Why are the changes needed?
Option variable in Spark historyServer log should be displayed as actual value instead of Some(XX)
Does this PR introduce any user-facing change?
No
How was this patch tested?
manual test