[SPARK-30231][SQL][PYTHON][FOLLOWUP] Make error messages clear in PySpark df.explain #26886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maropu
commented
Dec 14, 2019
maropu
commented
Dec 14, 2019
Member
Author
|
also cc: @HyukjinKwon |
viirya
approved these changes
Dec 14, 2019
Member
|
Oh, I didn't know you opened a PR already. Sure, this way works too. |
HyukjinKwon
approved these changes
Dec 14, 2019
|
Test build #115323 has finished for PR 26886 at commit
|
|
Test build #115328 has finished for PR 26886 at commit
|
dongjoon-hyun
approved these changes
Dec 14, 2019
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Merged to master.
Thank you, @maropu , @viirya , @HyukjinKwon !
Member
Author
|
Thank for taking care, @dongjoon-hyun ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr is a followup of #26861 to address minor comments from @viirya.
Why are the changes needed?
For better error messages.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually tested.