[SPARK-22393][SPARK-SHELL] spark-shell can't find imported types in class constructors, extends clause #19846
Conversation
|
Sorry, could not refactor the code better; since it makes heavy use of path-dependent types. |
|
OK, so this just affects the Scala 2.11 REPL in Spark (good, because the 2.12 version works a little differently and the fix is already in 2.12), and you've just copied in the fixed classes and injected the fixed impl? sounds reasonable. |
|
@srowen Yes, exactly. Tried to minimize the risks of any problems caused by this change. |
|
Test build #3998 has finished for PR 19846 at commit
|
|
@mpetruska, btw can you fill up the PR description about how it fixes? |
|
@HyukjinKwon : Hi, yes: this is the "retrofitting" of the original bug fix, which never made it to Scala 2.11. Instead of copy-pasting the original discussion, let me link the original PR. |
|
Merged to master |
4 participants
What changes were proposed in this pull request?
SPARK-22393
How was this patch tested?
With a new test case in
RepSuiteThis code is a retrofit of the Scala SI-9881 bug fix, which never made it into the Scala 2.11 branches. Pushing these changes directly to the Scala repo is not practical (see: scala/scala#6195).