Conversation
|
Test build #84226 has finished for PR 19829 at commit
|
|
Test build #84231 has finished for PR 19829 at commit
|
|
Looks like a fix for https://issues.apache.org/jira/browse/SPARK-19552 -- should that be reopened now that netty is deprecating 4.0.x so we can't do it "Later" anymore? |
|
@ash211 Good call. I will reopen it. |
| return transferred; | ||
| } | ||
|
|
||
| @Override |
There was a problem hiding this comment.
I prototyped this change internally for a different reason, and I chose to create an abstract class for all this boilerplate, which seems cleaner to me.
public abstract class AbstractFileRegion extends AbstractReferenceCounted implements FileRegion {
@Override
@SuppressWarnings("deprecation")
public final long transfered() {
return transferred();
}
@Override
public FileRegion retain() {
super.retain();
return this;
}
@Override
public FileRegion retain(int increment) {
super.retain(increment);
return this;
}
@Override
public FileRegion touch() {
return touch(null);
}
@Override
public FileRegion touch(Object hint) {
return this;
}
}
|
Test build #84668 has finished for PR 19829 at commit
|
|
Test build #84669 has finished for PR 19829 at commit
|
|
Test build #84670 has finished for PR 19829 at commit
|
|
Test build #84671 has finished for PR 19829 at commit
|
4 participants
What changes were proposed in this pull request?
Submitted this PR to see if there is anything broken.
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.