[SPARK-17338][SQL][follow-up] add global temp view #15424
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Test build #66701 has finished for PR 15424 at commit
|
cloud-fan
force-pushed
the
global-temp-view
branch
from
b93841b to
9928616
Compare
|
Test build #66704 has finished for PR 15424 at commit
|
cloud-fan
force-pushed
the
global-temp-view
branch
from
9928616 to
15efca6
Compare
rxin
reviewed
Oct 11, 2016
| } | ||
|
|
||
| /** | ||
| * Drop a local temporary view. |
Contributor
There was a problem hiding this comment.
explain what the return value means
rxin
reviewed
Oct 11, 2016
| * Local temporary view is session-scoped. Its lifetime is the lifetime of the session that | ||
| * created it, i.e. it will be automatically dropped when the session terminates. It's not | ||
| * tied to any databases, i.e. we can't use `db1.view1` to reference a local temporary view. | ||
| * |
Contributor
There was a problem hiding this comment.
can you add a line saying the return type was unit in Spark 2.0, but changed to boolean in Spark 2.1?
Contributor
|
LGTM other than the two minor comments. We also need a Python API for this, don't we? |
Contributor
|
LGTM pending Jenkins. |
|
Test build #66707 has finished for PR 15424 at commit
|
|
Test build #66720 has finished for PR 15424 at commit
|
Contributor
Author
|
merging to master! |
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request? address post hoc review comments for apache#14897 ## How was this patch tested? N/A Author: Wenchen Fan <[email protected]> Closes apache#15424 from cloud-fan/global-temp-view.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
address post hoc review comments for #14897
How was this patch tested?
N/A