Skip to content

[SPARK-1977][MLLIB] register mutable BitSet in MovieLenseALS #1319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nevillelyh wants to merge 1 commit into from
Closed

[SPARK-1977][MLLIB] register mutable BitSet in MovieLenseALS #1319

nevillelyh wants to merge 1 commit into from

Conversation

@nevillelyh
Copy link
Contributor

@nevillelyh nevillelyh commented Jul 7, 2014

No description provided.

@AmplabJenkins
Copy link

AmplabJenkins commented Jul 7, 2014

Can one of the admins verify this patch?

@mengxr
Copy link
Contributor

mengxr commented Jul 7, 2014

Jenkins, add to whitelist.

@mengxr
Copy link
Contributor

mengxr commented Jul 7, 2014

Jenkins, test this please.

@AmplabJenkins
Copy link

AmplabJenkins commented Jul 7, 2014

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented Jul 7, 2014

Merged build started.

mengxr
mengxr reviewed Jul 7, 2014
View reviewed changes
examples/src/main/scala/org/apache/spark/examples/mllib/MovieLensALS.scala Outdated
Copy link
Contributor

@mengxr mengxr Jul 7, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we import scala.collection.mutable here and use mutable.BitSet in the Kryo registrator?

@nevillelyh
Copy link
Contributor Author

nevillelyh commented Jul 7, 2014

@mengxr just realized that chill 0.4.0 was just released, will bump version instead of this fix.

@mengxr
Copy link
Contributor

mengxr commented Jul 7, 2014

Bumping the version requires more tasks to do, e.g., dependency/license check, regression check, etc. I would rather register mutable.BitSet for this PR.

@nevillelyh
Copy link
Contributor Author

nevillelyh commented Jul 7, 2014

Fair enough :)
Changed to import scala.collection.mutable instead.

@AmplabJenkins
Copy link

AmplabJenkins commented Jul 7, 2014

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented Jul 7, 2014

Merged build started.

@AmplabJenkins
Copy link

AmplabJenkins commented Jul 7, 2014

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

AmplabJenkins commented Jul 7, 2014

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16381/

@asfgit asfgit closed this in f7ce1b3 Jul 7, 2014
asfgit pushed a commit that referenced this pull request Jul 7, 2014
@nevillelyh @mengxr
[SPARK-1977][MLLIB] register mutable BitSet in MovieLenseALS
5044ba6 
Author: Neville Li <[email protected]>

Closes #1319 from nevillelyh/gh/SPARK-1977 and squashes the following commits:

1f0a355 [Neville Li] [SPARK-1977][MLLIB] register mutable BitSet in MovieLenseALS

(cherry picked from commit f7ce1b3)
Signed-off-by: Xiangrui Meng <[email protected]>
@mengxr
Copy link
Contributor

mengxr commented Jul 7, 2014

Merged. Thanks!

@AmplabJenkins
Copy link

AmplabJenkins commented Jul 7, 2014

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

AmplabJenkins commented Jul 7, 2014

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16386/

xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@nevillelyh @conviva-zz
[SPARK-1977][MLLIB] register mutable BitSet in MovieLenseALS
39a5b9f 
Author: Neville Li <[email protected]>

Closes apache#1319 from nevillelyh/gh/SPARK-1977 and squashes the following commits:

1f0a355 [Neville Li] [SPARK-1977][MLLIB] register mutable BitSet in MovieLenseALS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nevillelyh @AmplabJenkins @mengxr