Skip to content

Conversation

@YanjieGao
Copy link
Contributor

Hi all,
I want to submit a basic operator Intersect
For example , in sql case
select * from table1
intersect
select * from table2
So ,i want use this operator support this function in Spark SQL
This operator will return the the intersection of SparkPlan child table RDD .
JIRA:https://issues.apache.org/jira/browse/SPARK-2235

Hi all,
I want to submit a basic operator Intersect
For example , in sql case 
select * from table1
intersect
select * from table2
So ,i want use this operator support this function in Spark SQL  
This operator will return the  the intersection of SparkPlan child table RDD .
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@YanjieGao YanjieGao changed the title Spark SQL basicOperator add Intersect operator [SPARK-2235][SQL]Spark SQL basicOperator add Intersect operator Jun 22, 2014
@YanjieGao
Copy link
Contributor Author

hi all ,I have finished the INTERSECT operator ,and has update the 6 files this operator needed .
Now i need your help to review the code .Thanks a lot !

@YanjieGao
Copy link
Contributor Author

Hi all, I have resolved the conflict .

@marmbrus
Copy link
Contributor

marmbrus commented Jul 4, 2014

This is conflicting now that we merged the other PR.

test this please

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does hive support this? if so we should add a test to HiveQuerySuite too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hive doesn't support ,I will remove this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why this line always red

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, it says you deleted some whitespace after Nil.

@YanjieGao
Copy link
Contributor Author

Hi Michael,I have resolve the conflict .And modify as your suggestion

@YanjieGao
Copy link
Contributor Author

Thanks ,I add three blank after that line ,Now there aren't red lines.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space between ) and }

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space after ,

@marmbrus
Copy link
Contributor

marmbrus commented Jul 5, 2014

Thanks ,I add three blank after that line ,Now there aren't red lines.

If there is trailing whitespace we should remove it. It is okay if it is not code you added in the PR.

@YanjieGao
Copy link
Contributor Author

Thanks a lot, I have reformat the code style.

@asfgit asfgit closed this in 50561f4 Jul 8, 2014
@marmbrus
Copy link
Contributor

marmbrus commented Jul 8, 2014

Thanks, I've merged this into master. Did not apply cleanly to 1.0 so we'll backport it later.

@YanjieGao
Copy link
Contributor Author

Hi, Michael I also have a Skew Join pr need to be reviewed and need some suggestions .Could you help me review it ?I have test it can pass the testsuite .Thanks a lot

#1134

xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
Hi all,
I want to submit a basic operator Intersect
For example , in sql case
select * from table1
intersect
select * from table2
So ,i want use this operator support this function in Spark SQL
This operator will return the  the intersection of SparkPlan child table RDD .
JIRA:https://issues.apache.org/jira/browse/SPARK-2235

Author: Yanjie Gao <[email protected]>
Author: YanjieGao <[email protected]>

Closes apache#1150 from YanjieGao/patch-5 and squashes the following commits:

4629afe [YanjieGao] reformat the code
bdc2ac0 [YanjieGao] reformat the code as Michael's suggestion
3b29ad6 [YanjieGao] Merge remote branch 'upstream/master' into patch-5
1cfbfe6 [YanjieGao] refomat some files
ea78f33 [YanjieGao] resolve conflict and add annotation on basicOperator and remove HiveQl
0c7cca5 [YanjieGao] modify format problem
a802ca8 [YanjieGao] Merge remote branch 'upstream/master' into patch-5
5e374c7 [YanjieGao] resolve conflict in SparkStrategies and basicOperator
f7961f6 [Yanjie Gao] update the line less than
bdc4a05 [Yanjie Gao] Update basicOperators.scala
0b49837 [Yanjie Gao] delete the annotation
f1288b4 [Yanjie Gao] delete annotation
e2b64be [Yanjie Gao] Update basicOperators.scala
4dd453e [Yanjie Gao] Update SQLQuerySuite.scala
790765d [Yanjie Gao] Update SparkStrategies.scala
ac73e60 [Yanjie Gao] Update basicOperators.scala
d4ac5e5 [Yanjie Gao] Update HiveQl.scala
61e88e7 [Yanjie Gao] Update SqlParser.scala
469f099 [Yanjie Gao] Update basicOperators.scala
e5bff61 [Yanjie Gao] Spark SQL basicOperator add Intersect operator
udaynpusa pushed a commit to mapr/spark that referenced this pull request Jan 30, 2024
…s" message appears when spark session is starting (apache#1150)
mapr-devops pushed a commit to mapr/spark that referenced this pull request May 8, 2025
…s" message appears when spark session is starting (apache#1150)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants