review

maropu · maropu · commit cb182b888439 · 2021-05-07T09:12:48.000+09:00
diff --git a/sql/core/src/main/scala/org/apache/spark/sql/execution/ExpandExec.scala b/sql/core/src/main/scala/org/apache/spark/sql/execution/ExpandExec.scala
@@ -176,12 +176,12 @@ case class ExpandExec(
           val boundExpr = BindReferences.bindReference(exprs(col), attributeSeq)
           val ev = boundExpr.genCode(ctx)
           val inputVars = CodeGenerator.getLocalInputVariableValues(ctx, boundExpr)._1.toSeq
-          val argList = inputVars.map { v =>
-            s"${CodeGenerator.typeName(v.javaType)} ${v.variableName}"
-          }
           val paramLength = CodeGenerator.calculateParamLengthFromExprValues(inputVars)
           if (CodeGenerator.isValidParamLength(paramLength)) {
             val switchCaseFunc = ctx.freshName("switchCaseCode")
+            val argList = inputVars.map { v =>
+              s"${CodeGenerator.typeName(v.javaType)} ${v.variableName}"
+            }
             ctx.addNewFunction(switchCaseFunc,
               s"""
                  |private void $switchCaseFunc(${argList.mkString(", ")}) {
